Skip to content

Add image asset and update HomeHero component #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosueBrenes merged 1 commit into from
Apr 27, 2026
Merged

Add image asset and update HomeHero component #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added public/image.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 3 additions & 10 deletions src/components/blocks/home/HomeHero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,11 @@
)}
>
<div className="relative mx-auto max-w-5xl overflow-hidden rounded-lg border border-border/60 bg-card/50 p-2 shadow-xl ring-1 ring-border/40 dark:bg-background/30">
<img

Check warning on line 108 in src/components/blocks/home/HomeHero.tsx

View workflow job for this annotation

GitHub Actions / lint-and-build 

Using `<img>` could result in slower LCP and higher bandwidth. Consider using `<Image />` from `next/image` or a custom image loader to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element
alt=""
className="z-2 aspect-video rounded-md border border-border/40 object-cover dark:hidden"
alt="ACTA dashboard preview"
className="z-2 h-auto w-full rounded-md border border-border/40 object-contain"
height={1080}
src="https://storage.efferd.com/screen/dashboard-light.webp"
width={1920}
/>
<img
alt=""
className="hidden aspect-video rounded-md border border-border/40 object-cover dark:block"
height={1080}
src="https://storage.efferd.com/screen/dashboard-dark.webp"
src="/image.png"
width={1920}
/>
</div>
Expand Down
Loading