Automatically collect items obtained through Thief/Covet - #817
Merged
Conversation
This introduces a result dataclass for `handle_battle()` that reports things that have changed in that battle, such as Pokémon having taking damage -- or Pokémon having obtained new items through Pickup, Thief, or Covet. It then uses this result to automatically take any items that Pokémon have obtained using Thief or Covet. Fixes 40Cakes#664 Also, I noticed that there is actually a difference in the game data between RSE and FRLG with regards to held item tables for different species. For example, Meowth may hold a Nugget on FRLG but not on RSE. I've updated the species data file (and extract script) to reflect that. Fixes 40Cakes#781
pekempy
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This introduces a result dataclass for
handle_battle()that reports things that have changed in that battle, such as Pokémon having taking damage -- or Pokémon having obtained new items through Pickup, Thief, or Covet.It then uses this result to automatically take any items that Pokémon have obtained using Thief or Covet.
Fixes #664
Also, I noticed that there is actually a difference in the game data between RSE and FRLG with regards to held item tables for different species. For example, Meowth may hold a Nugget on FRLG but not on RSE.
I've updated the species data file (and extract script) to reflect that.
Fixes #781
Checklist
--line-length 120argument