Overlay: Fix section checklist on underwater routes - #815
Merged
Conversation
The encounter table on underwater routes is considered a 'surfing' table, but the player avatar does not have the 'Surfing' flag at that point (probably due to the different underwater sprite.) So the overlay assumed that the player was currently hunting _land_ animals and therefore trying to use the (empty) land encounters table to mark potential encounters in the section checklist yellow.
pekempy
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The encounter table on underwater routes is considered a 'surfing' table, but the player avatar does not have the 'Surfing' flag at that point (probably due to the different underwater sprite.)
So the overlay assumed that the player was currently hunting land animals and therefore trying to use the (empty) land encounters table to mark potential encounters in the section checklist yellow.
Checklist
--line-length 120argument