Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏡 과제 명세
any사용 금지✍️ 구현 요약 및 새로 배운 점
useInfiniteQuery를 활용해서 무한 스크롤을 구현했습니다IntersectionObserver와useRef로 스크롤 감지 후 자동으로 다음 페이지를 불러오게 구현했습니다localStorage로 게스트 세션을 유지해서 페이지를 새로고침해도 이전 별점이 유지됩니다group,group-hover를 활용해서 카드 hover 시 정보가 올라오는 효과를 구현했습니다💦 구현 과정에서 어려웠던 & 고민했던 부분
useInfiniteQuery의queryKey에 필터 값을 넣어야 필터 변경 시 자동으로 새로 fetch된다는 걸 이해하는 데 시간이 걸렸습니다min/max범위로 구현할지 단순 이상으로 구현할지 고민했습니다🙋♀️ 리뷰 요청 포인트 & 질문
MovieDetailPage에 로직이 많이 몰려있는데 분리하는 게 나을지 궁금합니다localStorage로 관리하는 방식이 적절한지 궁금합니다📷 결과물
(https://drive.google.com/file/d/11cVv7w_phgf2URKKLCHl_DXpglRFcJRL/view?usp=sharing)