Conversation
Returns vid
Save contact
Remove superfluous arg
Add update_contact
… calls MockPortalConnection only makes the assertions about API calls in it's __exit__() method
Make contact tests fail if code under test doesn't make the right API calls
Change save contact to create contact in test and simulator classes. Rename SaveContactClientError to UnsuccessfulCreateContact to match the Unsuccessful prefix that the existing exception-throwing simulators use.
Rename save_contact to create_contact
Author
|
#2 is the same thing with .gitignore removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They create/update a single contact.