rpc: adapt estimate_smart_fee to new estimatesmartfee RPC signature#20
Merged
ismaelsadeeq merged 1 commit intoApr 30, 2026
Merged
Conversation
ismaelsadeeq
force-pushed
the
04-2026-adapt-with-recent-api
branch
from
4a9a222 to
a859ea0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename verbosity_level to verbosity and add block_policy_only (default false) to match the updated estimatesmartfee RPC. With block_policy_only false the node selects the best available estimator and includes an estimator field in the result. Fix get_mempool_health_statistics to pass block_policy_only=false, which is now required for mempool_health_statistics to appear in the response.
Update tests: rename test_verbosity_level_forwarded_to_rpc, fix all call sites to match the new 4-argument param list, and add coverage for block_policy_only forwarding, estimator field passthrough, and the mempool health block_policy_only requirement.