Return a conversion failure error when CGImageCreate fails#205
Merged
complexspaces merged 1 commit intomasterfrom Sep 12, 2025
Merged
Return a conversion failure error when CGImageCreate fails#205complexspaces merged 1 commit intomasterfrom
complexspaces merged 1 commit intomasterfrom
Conversation
complexspaces
force-pushed
the
apple-image-creation-failures
branch
from
406f259 to
9ee48bf
Compare
complexspaces
force-pushed
the
apple-image-creation-failures
branch
from
9ee48bf to
375c7d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes an error handling change to
set_imageon macOS, which calls intoimage_from_pixelsto create a native image object from the supplied bytes. Previously if the image data wasn't valid for some reason, the call would panic. This isn't ideal as the error message is bad and could happen in the wild (even if these cases are more likely to be programmer errors).With these changes, those are now converted into
Error::ConversionFailureand gracefully returned. Given that this is the only place this error variant can be returned on theset_imagecodepath, it should still be easy to track down the root cause when/if needed.Closes #204