Compound-passport google oauth 2 - #31
Open
bryanrasmussen wants to merge 19 commits into
Open
Conversation
…when 3 configurations
…when 3 configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since google is shutting down openid support and older versions of oauth I needed to make oauth 2 work for my site. Had some troubles understanding the done function and how to structure my user.js but I finally got it working, I decided that in case someone still wanted to use the older google library for a while longer I would name mine google_oauth but that can be changed if it seems unlikely, this is also why I have made some changes to passport yml needs
The passport yml would look like
development:
baseURL: 'http://localhost/'
ssl_base: 'https://localhost/'
google_oauth:
clientID: client id goes here
secret: secret goes here
scope: space separated list of scope goes here, I just used "email"