feat: refactor miden-testing's MockChain to be used in the compiler's integration's test #2502
Draft
lima-limon-inc wants to merge 7 commits into0xMiden:nextfrom
Draft
feat: refactor miden-testing's MockChain to be used in the compiler's integration's test #2502lima-limon-inc wants to merge 7 commits into0xMiden:nextfrom
miden-testing's MockChain to be used in the compiler's integration's test #2502lima-limon-inc wants to merge 7 commits into0xMiden:nextfrom
Conversation
lima-limon-inc
force-pushed
the
fabrizioorsi/miden-testing-compiler
branch
2 times, most recently
from
be26aeb to
4367f48
Compare
mmagician
added
the
pr-from-maintainers
…kages Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
…rust packages" This reverts commit 4367f48.
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
lima-limon-inc
force-pushed
the
fabrizioorsi/miden-testing-compiler
branch
from
4367f48 to
d243d94
Compare
Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com>
lima-limon-inc
force-pushed
the
fabrizioorsi/miden-testing-compiler
branch
from
d243d94 to
663a203
Compare
…onent Signed-off-by: Tomas Fabrizio Orsi <tomas.orsi@lambdaclass.com> Suggested-by: Philipp Gackstatter <PhilippGackstatter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes 0xMiden/compiler#981
Note: This PR is still a work in progress
Changes:
NoteScript::from_packagein order to replicateAccountComponent::from_packageNoteBuilder::source_code, in order to encapsulate the two possible ways to create aNoteScriptin this context: either by aPackage(potentially obtained by the compiler) or aSourceManager+ dynamicLibrarys.MockChainBuilder::add_existing_account_from_componentsin order to create an account fromAccountComponents directly.I believe, with the addition of the
Packagein bothNoteScriptandNoteBuilder, we could remove several functions/structs from the compiler's test code, notably:create_note_from_packagecan be replaced withNoteBuilder.packageNoteCreationConfigis also handled byNoteBuilder