Open
Conversation
afa7789
force-pushed
the
openzeppelin/pausable
branch
from
53ab657 to
c9821c4
Compare
afa7789
changed the title
afa7789
force-pushed
the
openzeppelin/pausable
branch
3 times, most recently
from
35b42fe to
0b8fdc3
Compare
Contributor
Author
|
#2241 (comment) I have to also review myself to see if I have to implement it with user-defined objects. Not so sure yet. |
Contributor
No, user-defined objects (or as we call them "programmable assets") is something we are implementing on our end (primarily by @PhilippGackstatter). |
mmagician
added
the
pr-from-maintainers
Contributor
|
@afa7789 - I believe this needs to be rebased. |
Contributor
Author
Contributor
Yes - makes sense! |
…nality with comprehensive tests - Added note scripts for pausing and unpausing the regulated network fungible faucet. - Implemented tests to verify the pause and unpause procedures, including state checks and error handling for unauthorized access. - Ensured that distribution operations fail when the faucet is paused and succeed when unpaused. - Verified that the faucet starts in an unpaused state and correctly reflects state changes after pause/unpause operations. - Included tests for non-owner attempts to pause and unpause the faucet, ensuring proper error handling.
afa7789
force-pushed
the
openzeppelin/pausable
branch
from
202d92d to
84db04d
Compare
- Update MASM to use ownable instead of network_fungible re-exports - Update distribute signature (remove aux/execution_hint) - Use AccountComponentMetadata for component creation - Fix procedure_digest macro calls with NAME constant - Fix include path for regulated faucet masl
- Fix RpoRandomCoin import path (crypto::random::RpoRandomCoin) - Replace create_mint_note/MintNoteInputs with MintNote::create/MintNoteStorage - Fix create_p2id_note_exact import path - Remove FieldElement import (no longer re-exported) - Replace amount.into() with amount.as_canonical_u64() - Replace as_int() with as_canonical_u64() - Replace NetworkFungibleFaucet::owner_config_slot() with Ownable2Step::slot_name()
afa7789
force-pushed
the
openzeppelin/pausable
branch
from
84db04d to
dbb6302
Compare
…ulated_network_fungible.masm
…rk fungible faucet tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request centers on the introduction and integration of the PAUSABLE.masm module, enabling crucial pause and unpause functionality for the regulated network fungible faucet. This foundational module significantly enhances operational control and security within the system.
The changes involve implementing pausable capabilities for the RegulatedNetworkFungibleFaucet using PAUSABLE.masm, alongside refining existing module references and improving overall code hygiene.
To ensure its reliability, comprehensive tests have been added specifically for the pause/unpause flow of the regulated network fungible faucet, confirming PAUSABLE.masm correctly manages its operational state.
Waiting for the other PR to be merged, so we can see that the files on this are only related to pausable.