Conversation
norswap
left a comment
norswap
left a comment
There was a problem hiding this comment.
Sorry it took me so long — looking good, have you tried running this on Sepolia or another non-devnet testnet?
Few things to fix and a couple of questions, but we can merge this soon 🚀
| res = lib.send_json_rpc_request(host, 3, "debug_dumpBlock", ["latest"]) | ||
| response = json.loads(res) | ||
| allocs = response['result'] | ||
| lib.write_json_file(config.l1_allocs_path, allocs) |
There was a problem hiding this comment.
What happened to this? Oh I see it's handled by the contracts now?
deps.py
Outdated
There was a problem hiding this comment.
Will this install pnpm if it's not already installed?
There was a problem hiding this comment.
From my tests it looks like not.
There was a problem hiding this comment.
it seems you need a fairly recent version of pnpm that's why I thought to change it to update but let's keep it as install for now and address it if we see issues in future
| try: | ||
| _deploy_contracts_on_l1(config, tmp_l1) | ||
| finally: | ||
| os.remove(config.op_deploy_config_path) |
There was a problem hiding this comment.
Is there a reason we shouldn't delete this and pass the config.deploy_config_path (without the op) as DEPLOY_CONFIG_PATH below?
| '--l1-deployments', config.addresses_path, | ||
| '--outfile.l2', config.l2_genesis_path, | ||
| '--outfile.rollup', config.rollup_config_path | ||
| ], cwd=config.op_node_dir, log_file=log_file) |
There was a problem hiding this comment.
Just checking if the last two invocations require rolling (i.e. if they emit a lot of output, or something we might want to save)
There was a problem hiding this comment.
looking at the outputs, I think there is some potentially useful info here so doesn't hurt to save it imo
setup.py
Outdated
There was a problem hiding this comment.
This might have been merged? We could probably remove the whole fix.
setup.py
Outdated
There was a problem hiding this comment.
Can you update the README accordingly (same for the monorepo version)?
deps.py
Outdated
There was a problem hiding this comment.
This is broken — looks like after a certan time they prune most of the intermediate nightlies. For some reason, it looks like they often keep the 2nd of the month nightlies so I suggest we update to nightly-5ac78a9cd4b94dc53d1fe5e0f42372b28b5a7559 from 2024-06-02
remove custom tagging in the op monorepo
I have not tried this on non-devnet yet, I'd like to work on getting devnet working with ansible first. Do you think we need to test non-devnet deployments before we can merge this? |
2 participants
Works for devnet. Still need to update the production config template.