feat: add cross-platform dock/taskbar icon visibility toggle#72
Open
yuler wants to merge 8 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to toggle the visibility of the application icon in the Dock or taskbar, including cross-platform implementation for macOS, Windows, and Linux, and updates to the settings UI and store. The review identified a potential issue with the asynchronous loading of the settings store during the startup hook, which may lead to the store being unavailable or causing UI flickering on macOS. Additionally, a suggestion was made to improve the taskbar visibility logic on non-macOS platforms by iterating through all windows rather than targeting only the 'main' window.
…ctivation policy - Synchronously load settings store on startup to determine macOS activation policy once. - Set macOS activation policy before creating windows to avoid dock icon flickering. - Iterate through all managed webview windows except "indicator" to skip taskbar on non-macOS platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show_dock_iconsetting to the basic settings store with platform-specific defaults.set_dock_icon_visibleto dynamically toggle Dock (macOS) and Taskbar (Windows/Linux) icon visibility across all managed windows.Test plan