Skip to content

[Bug] Custom skulls not being loaded/rendered correctly #373

@MagicSweet-dev

Description

@MagicSweet-dev

Describe the bug

Custom skulls seem to be broken at the moment.
This is relevant for at least Minecraft 1.21.8 (Fabric), and, I presume, for other versions/platforms as well.

The breaking change was introduced somewhere in PR #347.
I built 2 artifacts: 1 before the merge, 1 after.

Here're my results

Before the merge (the head looks correct):
Image
Image


After the merge (the head looks incorrect):
Image
Image


ItemStack data I used for testing (output of /data command):

{Motion: [-1.4281966556759682E-20d, 0.0d, 8.653292407907E-21d], Health: 5s, Invulnerable: 0b, fall_distance: 0.0d, Air: 300s, OnGround: 1b, PortalCooldown: 0, Rotation: [220.90945f, 0.0f], Thrower: [I; -249100633, -1012314141, -1524243862, 410791525], Item: {components: {"minecraft:lore": [{color: "gray", text: "Custom Head ID: 24982", italic: 0b}, {color: "blue", text: "www.minecraft-heads.com", italic: 0b}], "minecraft:custom_name": {color: "gold", underlined: 1b, text: "Balloon (yellow)", bold: 1b, italic: 0b}, "minecraft:profile": {id: [I; -1713223855, -89568592, -1152436635, -1935019532], properties: [{name: "textures", value: "eyJ0ZXh0dXJlcyI6eyJTS0lOIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvY2IxYWU3YTQ3MTcyOTY1MWI1NjY3YjgxNjk0ZTQ5MjgwOGM1MDkwYzJiMTY4ZjBhOTE5MGZkMDAyZWU1MGEyNiJ9fX0="}]}}, count: 1, id: "minecraft:player_head"}, Pos: [-559.4203277452252d, 82.0d, 52.03132417812399d], PickupDelay: 0s, Fire: 0s, UUID: [I; -1027994245, 424169216, -1651982122, -1149444956], Age: 309s}

Steps to reproduce

1. Visit https://minecraft-heads.com/custom-heads/head/24982 (or any other custom head)
2. Copy & execute /give command

Link to crash-report if applicable

No response

Link to CustomSkinLoader.log if applicable

N/A

Link to latest.log if applicable

No response

[Only Forge User] Link to Forge Log if applicable

No response

Mod Version

14.26-Latest

Minecraft Version

1.21.8

Minecraft Launcher Name and Version

No response

Mod Loader

Fabric

Operating System

Windows

Before submitting a bug report

  • This bug wasn't already reported (I have searched bug reports on GitHub).

  • This is a valid bug (I am able to reproduce this on the latest dev build).

  • This problem is triggered in the latest version of the mod (if not the latest please upgrade the mod first)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions