From b4f98fc7776ccf1360cd4bdeabcdf16fe129edf1 Mon Sep 17 00:00:00 2001 From: Edson Yoshimaru Date: Tue, 8 Jul 2025 23:41:50 +0900 Subject: [PATCH] fix: javadoc of card reader class and update readme --- README.md | 2 +- .../java/com/github/wnameless/smartcard/CardReader.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 5431fd8..7479d52 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ CommandAPDU cmd1 = APDU.builder().setINS(INS.SELECT_FILE).setP1((byte) 0x04) CommandAPDU cmd2 = APDU.builder().setINS(INS.GET_DATA).setP1((byte) 0x11) .setData((byte) 0x00, (byte) 0x00).build(); // It's fine to use a byte array to set the data -ListMultimap res // Each value stores all ResponseAPDUs of a CardTerminal +Map> res // Each value stores all ResponseAPDUs of a CardTerminal = CardReader.getInstance().read(cmd1, cmd2); ``` diff --git a/src/main/java/com/github/wnameless/smartcard/CardReader.java b/src/main/java/com/github/wnameless/smartcard/CardReader.java index 765af6b..87b9b45 100644 --- a/src/main/java/com/github/wnameless/smartcard/CardReader.java +++ b/src/main/java/com/github/wnameless/smartcard/CardReader.java @@ -61,22 +61,22 @@ public static CardReader getInstance() { } /** - * Returns a Multimap<CardTerminal, ResponseAPDU> after executing a set of CommandAPDU on + * Returns a Map<CardTerminal, List<ResponseAPDU>> after executing a set of CommandAPDU on * all Smartcard readers. * * @param commands an array of CommandAPDU - * @return ListMultimap<CardTerminal, ResponseAPDU> + * @return Map<CardTerminal, List<ResponseAPDU>> */ public Map> read(CommandAPDU... commands) { return read(Arrays.asList(commands)); } /** - * Returns a Multimap<CardTerminal, ResponseAPDU> after executing a set of CommandAPDU on + * Returns a Map<CardTerminal, List<ResponseAPDU>> after executing a set of CommandAPDU on * all Smartcard readers. * * @param commands a List of CommandAPDU - * @return ListMultimap<CardTerminal, ResponseAPDU> + * @return Map<CardTerminal, List<ResponseAPDU>> */ public Map> read(List commands) { Map> responses = new LinkedHashMap<>();