fix: call e2eRotate on existing conversations [WPB-24528] (#20923)

Author: e-maad

apps/webapp/src/script/E2EIdentity/E2EIdentityEnrollment.ts

@@ -314,14 +314,19 @@ export class E2EIHandler extends TypedEventEmitter<Events> {
         },
         certificateTtl: this.certificateTtl,
         getAllConversations: async () => {
-          if (!isCertificateRenewal) {
-            return Promise.resolve([]);
+          if (is.undefined(this.core.service)) {
+            return [];
           }
           const conversations = await this.core.service.conversation.getConversations();
+
+          if (!is.array(conversations.found)) {
+            return [];
+          }
+
           return conversations.found
             .filter(conversation => is.nonEmptyString(conversation.group_id))
             .map(({group_id}) => ({
-              group_id,
+              group_id: group_id!,
             }));
         },
       });

libraries/core/src/messagingProtocols/mls/E2EIdentityService/E2EIServiceInternal.ts

@@ -276,8 +276,19 @@ export class E2EIServiceInternal {
       const newCrlDistributionPoints = await cx.saveX509Credential(identity, certificate);
       for (const conversation of conversations) {
         if (Boolean(conversation.group_id?.length)) {
-          const idAsBytes = Decoder.fromBase64(conversation.group_id).asBytes;
-          await cx.e2eiRotate(new ConversationId(idAsBytes));
+          try {
+            const idAsBytes = Decoder.fromBase64(conversation.group_id).asBytes;
+            const conversationId = new ConversationId(idAsBytes);
+
+            // Check if conversation exists before rotating
+            const conversationExists = await cx.conversationExists(conversationId);
+            if (conversationExists) {
+              await cx.e2eiRotate(conversationId);
+            }
+          } catch (error) {
+            // Log error but don't fail the entire enrollment if one conversation fails
+            this.logger.warn('Failed to rotate conversation', {groupId: conversation.group_id, error});
+          }
         } else {
           this.logger.error('No group id found in conversation');
         }