Skip to content

fix(drive): Correct default sort orders (WPB-24104)#4722

Open
ohassine wants to merge 4 commits intodevelopfrom
Correct-default-sort-orders
Open

fix(drive): Correct default sort orders (WPB-24104)#4722
ohassine wants to merge 4 commits intodevelopfrom
Correct-default-sort-orders

Conversation

@ohassine
Copy link
Copy Markdown
Member

@ohassine ohassine commented Apr 10, 2026 •
edited by github-actions bot
Loading

https://wearezeta.atlassian.net/browse/WPB-24104

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

  • Set FoldersFirst as default sorting in Shared Drive screen and search
  • Make FoldersFirst option not visible in DropDownMenu in shared drive search
  • Set NewestFirst as default sorting in Drive screen and search
  • Avoid loading data when navigating from Drive or Shared drive to Search

Shared Drive

Before After
screen-20260410-183053-1775838639930.mp4
Screen_recording_20260410_182648.mp4

Drive

Before After
screen-20260410-182944-1775838572829.mp4
screen-20260410-182944-1775838572829.mp4

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title fix (drive): Correct default sort orders (WPB-24104) fix(drive): Correct default sort orders (WPB-24104) Apr 13, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 17, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 45.05495% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.05%. Comparing base (3180bb4) to head (67bec4d).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...d/feature/cells/ui/search/SearchScreenViewModel.kt 20.51% 31 Missing ⚠️
...com/wire/android/feature/cells/ui/CellViewModel.kt 70.96% 3 Missing and 6 partials ⚠️
...id/feature/cells/ui/search/sort/SortRowWithMenu.kt 0.00% 4 Missing ⚠️
...id/feature/cells/ui/search/sort/SortingCriteria.kt 71.42% 4 Missing ⚠️
...roid/feature/cells/ui/search/sort/SortingMapper.kt 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (45.05%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4722      +/-   ##
===========================================
+ Coverage    49.88%   50.05%   +0.16%     
===========================================
  Files          602      602              
  Lines        20643    20684      +41     
  Branches      3290     3300      +10     
===========================================
+ Hits         10298    10353      +55     
+ Misses        9379     9360      -19     
- Partials       966      971       +5
Files with missing lines Coverage Δ
...e/android/feature/cells/ui/search/SearchUiState.kt 26.47% <100.00%> (ø)
...roid/feature/cells/ui/search/sort/SortingMapper.kt 20.00% <0.00%> (+20.00%) ⬆️
...id/feature/cells/ui/search/sort/SortRowWithMenu.kt 0.00% <0.00%> (ø)
...id/feature/cells/ui/search/sort/SortingCriteria.kt 71.87% <71.42%> (+7.58%) ⬆️
...com/wire/android/feature/cells/ui/CellViewModel.kt 50.84% <70.96%> (+0.66%) ⬆️
...d/feature/cells/ui/search/SearchScreenViewModel.kt 45.02% <20.51%> (+2.92%) ⬆️

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3180bb4...67bec4d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbakhtiarov sbakhtiarov Awaiting requested review from sbakhtiarov

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

At least 2 approving reviews are required to merge this pull request.

Assignees

@ohassine ohassine

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ohassine