IsInstanceOf changed in 2.1.3 check with static::object check added

[NielsLinde]

I've updated from 2.1.2 to 2.13 and there is a change in my messages.

For example :
Assert::isInstanceOf($myObject, MyClass::class, 'Not a valid object');

With version 2.1.2 it will return Not a valid object
With version 2.1.3 it will return Expected an object. Got: NULL

It seems to be related to this change:
bad8da8#diff-7bd03e2f6e9bd4ee8d0c85ead2263b222401f58506184bd6531505a6112f2d88R487

It this change intended to be added?
If so might it be a option for you to pass along the message to the static::object

public static function isInstanceOf(mixed $value, mixed $class, string $message = ''): object { static::object($value);

would be

public static function isInstanceOf(mixed $value, mixed $class, string $message = ''): object { static::object($value, $message);

[theofidry]

Confirming this was caused by #346.

At first glance the change makes sense, because static::string() does not take the passed $message. However, I think it makes more sense to pass it. Indeed, if you do:

Assert::isInstanceOf($value, $notAClass, $message);

I would argue having $notAClass not matching the type is a logic error, whereas passing a non object as $value, is a valid (invalid) input: you expect the assertion to fail there, and if you pass a message, you would expect this message to be used.

[shadowhand]

This was an oversight. When we do an internal validation using (eg) static::object($value) it should include $message:

- static::object($value);
+ static::object($value, $message);

[shadowhand]

Fixed in version 2.1.4.