vens should keep compiling on Windows, and right now it doesn't: #237 added syscall.Umask in generate, which doesn't exist on Windows, so GOOS=windows go build ./... fails. It's the only blocker today (checked the whole module), but nothing stops the next one from slipping in.
So handle it generally, not just this file:
- Add
GOOS=windows go build ./... to CI, so the whole class gets caught instead of one file at a time when someone happens to notice.
- Fix the current break behind build tags:
umask_unix.go with the real syscall, umask_other.go returning 0666.
this is just about the package staying buildable everywhere (windows/linux/darwrin)
vens should keep compiling on Windows, and right now it doesn't: #237 added
syscall.Umaskin generate, which doesn't exist on Windows, soGOOS=windows go build ./...fails. It's the only blocker today (checked the whole module), but nothing stops the next one from slipping in.So handle it generally, not just this file:
GOOS=windows go build ./...to CI, so the whole class gets caught instead of one file at a time when someone happens to notice.umask_unix.gowith the real syscall,umask_other.goreturning0666.this is just about the package staying buildable everywhere (windows/linux/darwrin)