Accept crates.io implementation checkpoint 5

Author: eldryoth

crates/cloud-sdk-cratesio/README.md

@@ -26,8 +26,9 @@ provider-neutral execution contracts from `cloud-sdk`.
 The crate is currently an unreleased `1.1.0` candidate. Provider identity and
 the endpoint, request-target, and static-download redirect boundaries are now
 implemented. Protected credential preparation is implemented behind `alloc`
-and awaiting its checkpoint pentest. API workflows and authenticated network
-execution remain unavailable until their reviewed checkpoints are complete.
+and has passed its checkpoint pentest and remediation retest. API workflows
+and authenticated network execution remain unavailable until their reviewed
+checkpoints are complete.
 
 ## Current Boundary
 

docs/CRATESIO_CREDENTIAL_POLICY.md

@@ -1,7 +1,8 @@
 # crates.io Credential Contract
 
-Status: Commit 5 implemented; incremental pentest pending. Candidate `1.1.0`
-is not publishable. No authenticated API workflow is claimed complete.
+Status: Commit 5 incremental pentest and remediation retest passed; GitHub
+approval is pending. Candidate `1.1.0` is not publishable. No authenticated API
+workflow is claimed complete.
 
 ## Source And Context
 
@@ -94,4 +95,6 @@ expiry, rotation schedules and remote invalidation. No hidden retries occur.
 - Source-inventory checker regression tests, default/alloc/all-feature builds,
   MSRV, Clippy, doctests, package verification, SBOM and repository gates.
 
-User pentest approval is still required for this checkpoint.
+The user confirmed a green remediation retest. The
+[permanent report](../security/pentest/cratesio-commit-5.md) records the exact
+reviewed range. GitHub CI and CodeQL must pass before Commit 6 begins.

docs/CRATESIO_SOURCE_LOCK.md

@@ -1,7 +1,7 @@
 # crates.io Source Lock
 
-Status: Commits 1 through 4 accepted; Commit 5 credential preparation is
-implemented and awaiting pentest in the unreleased `1.1.0` train. See the
+Status: Commits 1 through 5 have passed pentest; Commit 5 credential preparation
+awaits GitHub approval in the unreleased `1.1.0` train. See the
 [credential contract](CRATESIO_CREDENTIAL_POLICY.md).
 
 This lock establishes the finite reviewed scope for provider implementation. The

docs/cratesio-commit-plan.md

@@ -1,8 +1,8 @@
 # crates.io Commit Plan
 
-Status: selected unreleased `1.1.0` implementation train. Commits 1 through 4
-are accepted; Commit 5 is implemented and awaiting its incremental pentest.
-Stop here before starting Commit 6.
+Status: selected unreleased `1.1.0` implementation train. Commits 1 through 5
+have passed their pentests. Commit 5 is awaiting GitHub CI and CodeQL approval;
+stop here before starting Commit 6.
 
 ## Decision Summary
 
@@ -241,9 +241,14 @@ redirect boundary.
 
 ## Commit 5 - Credentials And Authentication Contexts
 
-Implementation status: implemented; pentest pending. Compare against accepted
-Commit 4 evidence commit `3c9b2ad6c230f069b75b1138cbbebecbe350aba7` through the
-Commit 5 implementation HEAD. Do not tag or publish this candidate checkpoint.
+Implementation status: incremental pentest and remediation retest passed.
+Reviewed range: accepted Commit 4 evidence commit
+`3c9b2ad6c230f069b75b1138cbbebecbe350aba7` through
+`e79273b7f4d4bafa0520e0b7105dd11012b782af`. The permanent
+[pentest report](../security/pentest/cratesio-commit-5.md) records the resolved
+test-coverage finding. The evidence commit containing that report becomes
+Commit 6's comparison baseline after GitHub CI and CodeQL pass. Do not tag or
+publish this candidate checkpoint.
 
 Implemented contract: [credential policy](CRATESIO_CREDENTIAL_POLICY.md).
 Protected storage and adapter preparation are available under `alloc`, without

release-notes/RELEASE_NOTES_1.1.0.md

@@ -200,14 +200,22 @@ full-service assessment are complete.
   API-token route comparison with the source inventory. Default features stay
   empty and no new third-party package is admitted.
 
-Commit 5 is implemented and awaiting incremental pentest against accepted
-checkpoint `3c9b2ad6c230f069b75b1138cbbebecbe350aba7`. The train remains blocked
-from publication until all numbered checkpoints are accepted.
+Commit 5 passed its incremental pentest and remediation retest from accepted
+checkpoint `3c9b2ad6c230f069b75b1138cbbebecbe350aba7` through reviewed commit
+`e79273b7f4d4bafa0520e0b7105dd11012b782af`. GitHub approval is pending. The train
+remains blocked from publication until all numbered checkpoints are accepted.
 
 Commit 5 pentest remediation adds independent fixed-operation method/path
 assertions at both constructor and emitted-material boundaries, including
 temporary-token revocation. This closes a regression-test gap without changing
-the currently correct runtime constructors. Remediation retest is pending.
+the currently correct runtime constructors. Both regression tests reject each
+of ten isolated method/path mutations; the restored snapshot passes. The final
+user-confirmed retest found no remaining issue.
+
+Checkpoint qualification also corrected the isolated package-feature gate to
+patch both unpublished local dependencies of `cloud-sdk-cratesio`, matching the
+main check gate. A mock-Cargo regression test asserts the actual complete
+package command. This changes only build verification, not SDK behavior.
 
 ### Maintenance Evidence
 

scripts/check_packaged_feature_graphs.sh

@@ -18,7 +18,8 @@ cargo package --locked -p cloud-sdk-hetzner --allow-dirty --all-features \
     --config 'patch.crates-io.cloud-sdk-sanitization.path="crates/cloud-sdk-sanitization"' \
     --config 'patch.crates-io.cloud-sdk-testkit.path="crates/cloud-sdk-testkit"'
 cargo package --locked -p cloud-sdk-cratesio --allow-dirty --all-features \
-    --config 'patch.crates-io.cloud-sdk.path="crates/cloud-sdk"'
+    --config 'patch.crates-io.cloud-sdk.path="crates/cloud-sdk"' \
+    --config 'patch.crates-io.cloud-sdk-sanitization.path="crates/cloud-sdk-sanitization"'
 scripts/check_packaged_reqwest_tests.sh
 
 printf '%s\n' "All six publishable package graphs passed Cargo verification."

scripts/test-cratesio-crate-boundary.py

@@ -4,7 +4,11 @@
 from __future__ import annotations
 
 import importlib.util
+import json
+import os
 import shutil
+import subprocess
+import sys
 import tempfile
 from pathlib import Path
 
@@ -264,6 +268,42 @@ def test_credential_inventory_and_feature_regressions_are_rejected() -> None:
     shutil.rmtree(root)
 
 
+def test_packaged_candidate_uses_both_local_dependency_patches() -> None:
+    with tempfile.TemporaryDirectory() as directory:
+        root = Path(directory)
+        scripts = root / "scripts"
+        scripts.mkdir()
+        shutil.copyfile(ROOT / "scripts/enforce_bundled_aws_lc.sh", scripts / "enforce_bundled_aws_lc.sh")
+        reqwest = scripts / "check_packaged_reqwest_tests.sh"
+        reqwest.write_text("#!/bin/sh\nexit 0\n", encoding="ascii")
+        reqwest.chmod(0o700)
+        binary = root / "bin"
+        binary.mkdir()
+        log = root / "cargo.jsonl"
+        cargo = binary / "cargo"
+        cargo.write_text(
+            f"#!{sys.executable}\n"
+            "import json, sys\n"
+            f"with open({str(log)!r}, 'a', encoding='ascii') as output:\n"
+            "    output.write(json.dumps(sys.argv[1:]) + '\\n')\n",
+            encoding="ascii",
+        )
+        cargo.chmod(0o700)
+        environment = dict(os.environ, PATH=str(binary) + os.pathsep + os.environ["PATH"])
+        result = subprocess.run(
+            ["sh", str(ROOT / "scripts/check_packaged_feature_graphs.sh")],
+            cwd=root, env=environment, text=True, capture_output=True, check=False,
+        )
+        assert result.returncode == 0, result
+        calls = [json.loads(line) for line in log.read_text(encoding="ascii").splitlines()]
+        provider_calls = [call for call in calls if "cloud-sdk-cratesio" in call]
+        assert provider_calls == [[
+            "package", "--locked", "-p", "cloud-sdk-cratesio", "--allow-dirty", "--all-features",
+            "--config", 'patch.crates-io.cloud-sdk.path="crates/cloud-sdk"',
+            "--config", 'patch.crates-io.cloud-sdk-sanitization.path="crates/cloud-sdk-sanitization"',
+        ]], provider_calls
+
+
 def main() -> None:
     tests = (
         test_repository_boundary,
@@ -275,6 +315,7 @@ def main() -> None:
         test_endpoint_code_and_extra_modules_are_rejected,
         test_unrelated_crate_dependency_is_rejected,
         test_credential_inventory_and_feature_regressions_are_rejected,
+        test_packaged_candidate_uses_both_local_dependency_patches,
     )
     for test in tests:
         test()

security/pentest/cratesio-commit-5.md

@@ -0,0 +1,87 @@
+# crates.io Commit 5 Pentest Report
+
+Status: PASS
+Assessment: INCREMENTAL
+Baseline: 3c9b2ad6c230f069b75b1138cbbebecbe350aba7
+Range-End: e79273b7f4d4bafa0520e0b7105dd11012b782af
+Reviewed-Commit: e79273b7f4d4bafa0520e0b7105dd11012b782af
+Tester: eldryoth
+Scope: crates.io protected credentials, authentication contexts, scoped adapter
+material, caller-buffer cleanup, rotation, and source-inventory regression
+coverage introduced after the accepted Commit 4 checkpoint.
+Date: 2026-09-05
+
+## Summary
+
+The independent incremental assessment identified one low-severity regression
+test gap, without a demonstrated runtime exploit. The current constructors
+were correct. The test gap was remediated in `e79273b7` without changing SDK
+runtime behavior. The user confirmed the final retest is green with no
+remaining finding.
+
+## Finding Count
+
+| Severity | Open findings |
+| --- | ---: |
+| Critical | 0 |
+| High | 0 |
+| Medium | 0 |
+| Low | 0 |
+
+## Findings And Remediation
+
+### Fixed credential operations lacked independent regression assertions
+
+The original material test compared its method with the same context it was
+testing, and header/JSON cases lacked independent target assertions. An
+incorrect temporary-token publish constructor could therefore pass both the
+credential unit tests and the separate source-inventory checker.
+
+Independent literal method and target assertions now cover publish, temporary
+token revocation, OIDC exchange, email confirmation and invitation acceptance.
+Constructor tests cover production and staging. Material callbacks separately
+assert the emitted method and complete target, including secret path suffixes;
+API-token material is also checked. Expected values are not derived from the
+context under test.
+
+In an isolated tracked snapshot, each fixed constructor's method and target
+was mutated separately. Both regression tests rejected all ten mutations;
+restoring the source made the snapshot tests pass. These probes never changed
+the working repository's runtime constructors.
+
+## Verification
+
+- Credential all-feature tests, doctests and alloc-only tests pass, including
+  cleanup, origin rejection, formatting, redaction and compile-fail boundaries.
+- The fail-closed Rust test checker passes for the provider source tree.
+- Full repository checks and SBOM freshness checks pass after remediation.
+- All twelve supported compiler checks from Rust `1.92.0` through `1.98.1`
+  pass for the complete workspace, all targets and all features.
+- All six packaged crate graphs verify; workspace documentation builds with
+  warnings denied, and documentation links pass validation.
+- Dependency policy and fresh RustSec scans pass for all four lockfiles. Live
+  crates.io source, endpoint and drift checks report no change; exact library
+  pins and pinned Cargo security/fuzz tools are current.
+- Release-plan validation passes, and a publication dry run correctly refuses
+  the non-public candidate milestone. No crate is selected for publication.
+- The root `PENTEST.md` scratch report is absent.
+
+## Boundaries
+
+The review does not turn the trusted adapter callback into an authenticated
+client. Callback obligations, remote JWT authentication, deferred execution
+and mutation controls, and cleanup exclusions for aborts and external copies
+remain documented in the [credential contract](../../docs/CRATESIO_CREDENTIAL_POLICY.md).
+Syntax validation is variable-time; this checkpoint does not claim hardware
+constant-time behavior or regulated-environment accreditation.
+
+## Result
+
+Commit 5 passed its final independent retest at the reviewed commit above.
+The evidence checkpoint also fixes a package-verification recipe discovered
+during final qualification: both unpublished local provider dependencies must
+be patched when checking the packaged crate. An argument-level mock-Cargo test
+covers that recipe, and actual package verification passed. This build-check
+correction and the documentation do not change the assessed runtime boundary.
+GitHub CI and CodeQL must pass before Commit 6 begins. Candidate
+`1.1.0` remains blocked from tagging and crate publication.