fix

Author: KirIgor

lib/umbrellio_utils/click_house.rb

@@ -104,10 +104,12 @@ def pg_table_connection(table)
     def with_temp_table(
       dataset, temp_table_name:, primary_key: [:id], primary_key_types: [:integer], **opts, &
     )
-      UmbrellioUtils::Database.create_temp_table(
-        nil, primary_key:, primary_key_types:, temp_table_name:, &
-      )
-      populate_temp_table!(temp_table_name, dataset)
+      unless DB.table_exists?(temp_table_name)
+        UmbrellioUtils::Database.create_temp_table(
+          nil, primary_key:, primary_key_types:, temp_table_name:, &
+        )
+        populate_temp_table!(temp_table_name, dataset)
+      end
       UmbrellioUtils::Database.with_temp_table(nil, primary_key:, temp_table_name:, **opts, &)
     end
 

spec/support/database.rb

@@ -6,8 +6,8 @@
   db_name = "umbrellio_utils_test"
   DB = Sequel.postgres(
     "umbrellio_utils_test",
-    user: "user",
-    password: "pass",
+    user: "igor",
+    password: "password",
     host: "localhost",
     port: 5432,
   )

spec/umbrellio_utils/clickhouse_spec.rb

@@ -83,13 +83,30 @@
   end
 
   describe "#with_temp_table" do
-    specify do
-      result = []
-      dataset = ch.from(:test).order(:id)
-      ch.with_temp_table(dataset, temp_table_name: "some_test_table", page_size: 1) do |batch|
-        result << batch
+    let(:result) { [] }
+    let(:dataset) { ch.from(:test).order(:id) }
+
+    context "when no temp table" do
+      before { DB.drop_table?(:some_test_table) }
+
+      specify do
+        ch.with_temp_table(dataset, temp_table_name: "some_test_table", page_size: 1) do |batch|
+          result << batch
+        end
+        expect(result).to eq([[3], [2], [1]])
+      end
+    end
+
+    context "when table already exist" do
+      before { DB.create_table("some_test_table") { primary_key :id } }
+      before { DB[:some_test_table].multi_insert([{ id: 4 }, { id: 5 }, { id: 6 }]) }
+
+      it "takes from existing" do
+        ch.with_temp_table(dataset, temp_table_name: "some_test_table", page_size: 1) do |batch|
+          result << batch
+        end
+        expect(result).to eq([[6], [5], [4]])
       end
-      expect(result).to eq([[3], [2], [1]])
     end
   end