imporvements for mac and steam socks

Author: malytomas

sources/libcore/concurrent/concurrent.cpp

@@ -778,10 +778,12 @@ namespace cage
 			__except (EXCEPTION_EXECUTE_HANDLER)
 			{}
 	#pragma warning(pop)
-#endif
 
-#ifdef CAGE_SYSTEM_LINUX
+#elif defined(CAGE_SYSTEM_LINUX)
 			prctl(PR_SET_NAME, name.c_str(), 0, 0, 0);
+
+#elif defined(CAGE_SYSTEM_MAC)
+			pthread_setname_np(name.c_str());
 #endif
 		}
 

sources/libcore/errors/crashHandlerMac.cpp

@@ -146,7 +146,6 @@ extern "C"
 	kern_return_t catch_mach_exception_raise(mach_port_t exception_port, mach_port_t thread, mach_port_t task, exception_type_t exception, exception_data_t code, mach_msg_type_number_t code_count)
 	{
 		using namespace cage;
-		thread_suspend(thread);
 		privat::crashHandlerSafeWrite(Stringizer() + "mach exception: " + excToStr(exception) + " (" + exception + ")\n");
 		if (code_count > 0)
 			privat::crashHandlerSafeWrite(Stringizer() + "code[0]: " + code[0] + "\n");
@@ -155,7 +154,7 @@ extern "C"
 		writeThreadInfo(thread);
 		const auto regs = writeRegisters(thread);
 		printStack(regs.first, regs.second, thread);
-		thread_resume(thread);
+		privat::crashHandlerSafeWrite("mach exception handler done\n");
 		// let the system continue propagating the exception
 		return KERN_FAILURE;
 	}

sources/libcore/errors/crashHandlerSignals.cpp

@@ -42,7 +42,7 @@ namespace cage
 		void crashHandlerPrintStack()
 		{
 			// backtrace (best-effort; not strictly async-signal-safe)
-			static constexpr int MaxFrames = 256;
+			static constexpr int MaxFrames = 100;
 			void *frames[MaxFrames];
 			int n = backtrace(frames, MaxFrames);
 			if (n <= 0)

sources/libcore/network/steam.cpp

@@ -135,14 +135,12 @@ namespace cage
 			{
 				InitializerSockets()
 				{
+					SteamNetworkingSockets_SetServiceThreadInitCallback(+[]() { currentThreadName("steam sockets"); });
+					SteamNetworkingErrMsg msg;
+					if (!GameNetworkingSockets_Init(nullptr, msg))
 					{
-						SteamNetworkingSockets_SetServiceThreadInitCallback(+[]() { currentThreadName("steam sockets"); });
-						SteamNetworkingErrMsg msg;
-						if (!GameNetworkingSockets_Init(nullptr, msg))
-						{
-							CAGE_LOG_THROW(msg);
-							CAGE_THROW_ERROR(Exception, "failed to initialize steam sockets networking library");
-						}
+						CAGE_LOG_THROW(msg);
+						CAGE_THROW_ERROR(Exception, "failed to initialize steam sockets networking library");
 					}
 				}
 				~InitializerSockets() { GameNetworkingSockets_Kill(); }
@@ -156,6 +154,11 @@ namespace cage
 				sockets = SteamNetworkingSockets();
 				utils = SteamNetworkingUtils();
 			}
+			if (!sockets || !utils)
+			{
+				CAGE_LOG(SeverityEnum::Note, "steamsocks", Stringizer() + "sockets: " + sockets + ", utils: " + utils);
+				CAGE_THROW_ERROR(Exception, "steam sockets api pointer is invalid");
+			}
 			CAGE_ASSERT(sockets);
 			CAGE_ASSERT(utils);
 
@@ -164,8 +167,12 @@ namespace cage
 				InitializerConfiguration()
 				{
 					utils->SetDebugOutputFunction((ESteamNetworkingSocketsDebugOutputType)(sint32)confDebugLogLevel, &debugOutputHandler);
-					utils->SetGlobalConfigValueFloat(k_ESteamNetworkingConfig_FakePacketLoss_Send, confSimulatedPacketLoss * 100);
-					utils->SetGlobalConfigValueInt32(k_ESteamNetworkingConfig_FakePacketLag_Send, (sint32)confSimulatedPacketDelay);
+					const float packetLoss = confSimulatedPacketLoss * 100;
+					const sint32 packetDelay = (sint32)confSimulatedPacketDelay;
+					if (packetLoss != 0 || packetDelay != 0)
+						CAGE_LOG(SeverityEnum::Warning, "steamsocks", Stringizer() + "setting packet loss: " + packetLoss + " %, packet delay: " + packetDelay + " ms");
+					utils->SetGlobalConfigValueFloat(k_ESteamNetworkingConfig_FakePacketLoss_Send, packetLoss);
+					utils->SetGlobalConfigValueInt32(k_ESteamNetworkingConfig_FakePacketLag_Send, packetDelay);
 					utils->SetGlobalConfigValueInt32(k_ESteamNetworkingConfig_IPLocalHost_AllowWithoutAuth, 1);
 				}
 			};