Merge branch 'main' of https://github.com/tinyhumansai/tinymcp into legacy-test-renames

Author: senamakel

crates/tinymcp-bus/src/config/mod_tests.rs

@@ -194,7 +194,7 @@ fn server_env_serializes_in_a_stable_order() {
 fn a_client_config_decodes_from_the_empty_object() {
     let config: McpClientConfig = serde_json::from_value(json!({})).expect("empty object decodes");
     assert!(config.enabled);
-    assert!(config.servers.is_empty());
+    assert_eq!(config.servers.len(), 0);
     assert_eq!(config.proxy, None);
     assert_eq!(config.registry_auth, McpRegistryAuthConfig::default());
 }
@@ -309,7 +309,7 @@ fn a_redacted_registry_auth_never_serializes_a_secret() {
 fn a_proxy_decodes_from_the_empty_object_with_nothing_set() {
     let proxy: McpProxyConfig = serde_json::from_value(json!({})).expect("empty object decodes");
     assert_eq!(proxy, McpProxyConfig::default());
-    assert!(proxy.no_proxy.is_empty());
+    assert_eq!(proxy.no_proxy.len(), 0);
 }
 
 #[test]

crates/tinymcp-bus/src/registry/mod_tests.rs

@@ -495,7 +495,7 @@ fn a_summary_tolerates_everything_optional_being_absent() {
     assert_eq!(summary.use_count, 0);
     assert!(!summary.is_deployed);
     assert!(!summary.official);
-    assert!(summary.source.is_empty());
+    assert_eq!(summary.source.len(), 0);
 }
 
 #[test]

crates/tinymcp-bus/src/transport/mod_tests.rs

@@ -272,7 +272,7 @@ fn an_error_result_is_flagged_and_carries_its_message() {
 #[test]
 fn text_skips_json_blocks_but_output_renders_them() {
     let result = McpToolResult::json(json!({ "key": "value" }));
-    assert!(result.text().is_empty());
+    assert_eq!(result.text().len(), 0);
     assert!(result.output().contains("key"));
 }
 
@@ -344,7 +344,7 @@ fn output_for_llm_falls_back_when_there_is_no_markdown() {
 #[test]
 fn a_default_tool_result_is_empty_and_successful() {
     let result = McpToolResult::default();
-    assert!(result.content.is_empty());
+    assert_eq!(result.content.len(), 0);
     assert!(!result.is_error);
     assert_eq!(result.output(), "");
 }
@@ -387,8 +387,8 @@ fn protected_resource_metadata_decodes_with_only_its_resource() {
     let metadata: ProtectedResourceMetadata =
         serde_json::from_value(json!({ "resource": "https://example.test/mcp" })).unwrap();
     assert_eq!(metadata.resource, "https://example.test/mcp");
-    assert!(metadata.authorization_servers.is_empty());
-    assert!(metadata.scopes_supported.is_empty());
+    assert_eq!(metadata.authorization_servers.len(), 0);
+    assert_eq!(metadata.scopes_supported.len(), 0);
 }
 
 #[test]
@@ -397,7 +397,7 @@ fn authorization_server_metadata_decodes_with_only_its_issuer() {
         serde_json::from_value(json!({ "issuer": "https://auth.test" })).unwrap();
     assert_eq!(metadata.issuer, "https://auth.test");
     assert_eq!(metadata.token_endpoint, None);
-    assert!(metadata.code_challenge_methods_supported.is_empty());
+    assert_eq!(metadata.code_challenge_methods_supported.len(), 0);
 }
 
 #[test]

crates/tinymcp/src/audit/store/mod_tests.rs

@@ -296,7 +296,7 @@ fn an_offset_skips_the_most_recent_records() {
 
 #[test]
 fn an_empty_log_lists_nothing() {
-    assert!(store().list(&all()).unwrap().is_empty());
+    assert_eq!(store().list(&all()).unwrap().len(), 0);
 }
 
 #[test]

crates/tinymcp/src/registry/config_doc/mod_tests.rs

@@ -237,7 +237,7 @@ fn a_declaration_becomes_a_row_keyed_by_its_name() {
     assert_eq!(row.display_name, "fs");
     assert_eq!(row.command_kind, CommandKind::Node);
     assert_eq!(row.installed_at, 42);
-    assert!(row.env_keys.is_empty());
+    assert_eq!(row.env_keys.len(), 0);
 }
 
 #[test]
@@ -274,7 +274,7 @@ fn a_null_args_list_and_a_null_flag_read_as_absent() {
         "mcpServers": { "a": { "command": "c", "args": null, "enabled": null, "env": null, "url": null } }
     }))
     .unwrap();
-    assert!(declared[0].args.is_empty());
+    assert_eq!(declared[0].args.len(), 0);
     assert!(declared[0].enabled);
     assert_eq!(declared[0].credentials, None);
 }
@@ -346,8 +346,8 @@ async fn applying_to_an_empty_store_installs_every_declared_server() {
         .unwrap();
 
     assert_eq!(names(&report.installed), ["hosted", "local"]);
-    assert!(report.updated.is_empty());
-    assert!(report.removed.is_empty());
+    assert_eq!(report.updated.len(), 0);
+    assert_eq!(report.removed.len(), 0);
 
     let local = registry
         .store()
@@ -388,9 +388,9 @@ async fn a_server_absent_from_the_document_is_removed() {
 
     assert_eq!(names(&report.removed), ["gone"]);
     assert_eq!(report.removed[0].server_id, "id-gone");
-    assert!(report.installed.is_empty());
-    assert!(report.updated.is_empty());
-    assert!(report.connect_queued.is_empty());
+    assert_eq!(report.installed.len(), 0);
+    assert_eq!(report.updated.len(), 0);
+    assert_eq!(report.connect_queued.len(), 0);
     assert!(registry.store().find_server("id-gone").unwrap().is_none());
 }
 
@@ -410,10 +410,10 @@ async fn re_applying_what_a_read_shows_changes_nothing_and_keeps_credentials() {
 
     let report = registry.apply_config_doc(&doc).await.unwrap();
 
-    assert!(report.installed.is_empty());
-    assert!(report.updated.is_empty());
-    assert!(report.removed.is_empty());
-    assert!(report.connect_queued.is_empty());
+    assert_eq!(report.installed.len(), 0);
+    assert_eq!(report.updated.len(), 0);
+    assert_eq!(report.removed.len(), 0);
+    assert_eq!(report.connect_queued.len(), 0);
     assert_eq!(registry.store().load_env_values("id-a").unwrap(), stored);
 }
 
@@ -504,7 +504,7 @@ async fn a_disabled_server_is_updated_but_not_connected() {
         .unwrap();
 
     assert_eq!(names(&report.updated), ["a"]);
-    assert!(report.connect_queued.is_empty());
+    assert_eq!(report.connect_queued.len(), 0);
     assert!(!registry.store().get_server("id-a").unwrap().enabled);
 }
 

crates/tinymcp/src/registry/connections/mod_tests.rs

@@ -416,7 +416,7 @@ async fn a_fresh_map_holds_nothing() {
     assert_eq!(connections.connected_count().await, 0);
     assert!(!connections.is_connected("srv-1").await);
     assert!(connections.tools_for("srv-1").await.is_none());
-    assert!(connections.connected_overview().await.is_empty());
+    assert_eq!(connections.connected_overview().await.len(), 0);
 }
 
 #[tokio::test]

crates/tinymcp/src/registry/curation/mod_tests.rs

@@ -47,7 +47,7 @@ fn every_canonical_name_is_fully_qualified() {
     // A bare vendor word here would badge far more than intended.
     for name in OFFICIAL_SERVERS {
         assert!(name.contains('/'), "{name} is not a qualified name");
-        assert!(!name.trim().is_empty());
+        assert_ne!(name.trim().len(), 0);
     }
 }
 
@@ -100,7 +100,7 @@ fn a_row_arriving_with_the_badge_set_has_it_cleared() {
 fn badging_an_empty_catalog_does_nothing() {
     let mut servers: Vec<RegistryServerSummary> = Vec::new();
     tag_official(&mut servers);
-    assert!(servers.is_empty());
+    assert_eq!(servers.len(), 0);
 }
 
 #[test]
@@ -183,7 +183,7 @@ fn filtering_reports_the_full_count_when_it_drops_everything() {
     // user as "there is nothing here".
     let mut servers = vec![server("a/one"), server("b/two"), server("c/three")];
     assert_eq!(retain_perfect_servers(&mut servers), 3);
-    assert!(servers.is_empty());
+    assert_eq!(servers.len(), 0);
 }
 
 #[test]

crates/tinymcp/src/registry/ops/mod_tests.rs

@@ -175,12 +175,12 @@ fn a_connection_with_no_schema_requires_nothing() {
         Some("https://api.test/mcp"),
     )]));
 
-    assert!(required.is_empty());
+    assert_eq!(required.len(), 0);
 }
 
 #[test]
 fn a_server_with_no_connections_requires_nothing() {
-    assert!(collect_required_env_keys(&detail(Vec::new())).is_empty());
+    assert_eq!(collect_required_env_keys(&detail(Vec::new())).len(), 0);
 }
 
 // ---------------------------------------------------------------------------
@@ -201,8 +201,8 @@ fn a_hosted_connection_becomes_a_remote_install_with_no_command() {
             url: "https://api.test/mcp".into()
         }
     );
-    assert!(command.is_empty());
-    assert!(args.is_empty());
+    assert_eq!(command.len(), 0);
+    assert_eq!(args.len(), 0);
 }
 
 #[test]
@@ -466,7 +466,7 @@ async fn a_server_that_is_turned_off_is_not_reconnected_when_its_credentials_cha
         .unwrap();
 
     assert_eq!(outcome.status, UpdateEnvStatus::Disabled);
-    assert!(outcome.tools.is_empty());
+    assert_eq!(outcome.tools.len(), 0);
     assert_eq!(
         registry
             .store()
@@ -1140,7 +1140,7 @@ async fn a_connection_test_reaches_the_server_without_installing_it() {
 
     assert_eq!(tools.len(), 1);
     assert_eq!(tools[0].name, "forecast");
-    assert!(registry.installed_list().unwrap().is_empty());
+    assert_eq!(registry.installed_list().unwrap().len(), 0);
 }
 
 #[tokio::test]
@@ -1322,7 +1322,7 @@ async fn the_facade_hands_out_the_pieces_a_host_drives_directly() {
     let (handle, _receiver) = registry.vault().request("API_KEY").await;
     assert!(registry.vault().submit(&handle, "sekrit".into()).await);
     assert_eq!(registry.oauth().pending_count(), 0);
-    assert!(registry.connected_overview().await.is_empty());
+    assert_eq!(registry.connected_overview().await.len(), 0);
 }
 
 #[tokio::test]
@@ -1480,7 +1480,7 @@ async fn installing_and_connecting_reports_the_install_even_when_the_connect_fai
         .await
         .expect("the install succeeded even though the connect did not");
 
-    assert!(outcome.tools.is_empty());
+    assert_eq!(outcome.tools.len(), 0);
     assert_eq!(registry.installed_list().unwrap().len(), 1);
 }
 

crates/tinymcp/src/registry/setup/mod_tests.rs

@@ -207,7 +207,7 @@ async fn resolving_leaves_the_handles_in_place() {
 #[tokio::test]
 async fn resolving_nothing_yields_nothing() {
     let vault = SecretVault::new();
-    assert!(vault.resolve(&HashMap::new()).await.unwrap().is_empty());
+    assert_eq!(vault.resolve(&HashMap::new()).await.unwrap().len(), 0);
 }
 
 // ---------------------------------------------------------------------------

crates/tinymcp/src/registry/sources/official/mod_tests.rs

@@ -64,9 +64,9 @@ fn a_row_with_no_server_key_is_a_parse_error_rather_than_a_blank_card() {
 
 #[test]
 fn an_empty_response_yields_no_rows() {
-    assert!(list_response(&json!([]), None).into_summaries().is_empty());
+    assert_eq!(list_response(&json!([]), None).into_summaries().len(), 0);
     let empty: OfficialListResponse = serde_json::from_value(json!({})).unwrap();
-    assert!(empty.into_summaries().is_empty());
+    assert_eq!(empty.into_summaries().len(), 0);
 }
 
 // ---------------------------------------------------------------------------
@@ -82,7 +82,7 @@ fn a_row_offering_no_way_to_connect_is_dropped() {
         None,
     );
 
-    assert!(response.into_summaries().is_empty());
+    assert_eq!(response.into_summaries().len(), 0);
 }
 
 #[test]
@@ -117,7 +117,7 @@ fn a_deprecated_row_is_dropped() {
         None,
     );
 
-    assert!(response.into_summaries().is_empty());
+    assert_eq!(response.into_summaries().len(), 0);
 }
 
 #[test]
@@ -905,7 +905,7 @@ async fn a_page_past_the_end_of_the_chain_comes_back_empty() {
         .await
         .expect("running out of pages is not a failure");
 
-    assert!(servers.is_empty());
+    assert_eq!(servers.len(), 0);
     assert_eq!(total_pages, 5);
 }