Skip to content

Commit ebcd0b1

Browse files
Remove min_length requirement on deprecated legacy tasks
1 parent a9c59ca commit ebcd0b1

2 files changed

Lines changed: 18 additions & 10 deletions

File tree

‎apis/workflows/v1/job.proto‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,6 @@ option features.field_presence = IMPLICIT;
1414

1515
// SubmitJobRequest submits and schedules a job for execution. The job can have multiple root tasks.
1616
message SubmitJobRequest {
17-
// The root tasks for the job.
18-
repeated SingleTaskSubmission legacy_tasks = 1 [(buf.validate.field).repeated = {
19-
min_items: 1
20-
max_items: 64
21-
}];
2217
// The root tasks for the job.
2318
TaskSubmissions tasks = 5;
2419
// The name of the job.
@@ -27,6 +22,15 @@ message SubmitJobRequest {
2722
string trace_parent = 3 [(buf.validate.field).string.min_len = 1];
2823
// Optional. The ID of the automation that submits this job.
2924
tilebox.v1.ID automation_id = 4;
25+
26+
// The root tasks for the job. This field is deprecated and will be removed in the future. Kept around for backwards
27+
// compatibility.
28+
repeated SingleTaskSubmission legacy_tasks = 1 [
29+
deprecated = true,
30+
// we support more than that due to grouping and tree spawning, but we rather want to encourage users
31+
// to update their clients to use the new field which has way less serialization overhead.
32+
(buf.validate.field).repeated.max_items = 1000
33+
];
3034
}
3135

3236
// GetJobRequest requests details for a job.

‎apis/workflows/v1/task.proto‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,18 @@ message ComputedTask {
3636
// If not set, the display message specified upon task submission will be kept.
3737
string display = 2;
3838
// A list of sub-tasks that the just computed task spawned.
39-
repeated SingleTaskSubmission legacy_sub_tasks = 3 [
40-
deprecated = true,
41-
(buf.validate.field).repeated.max_items = 64
42-
];
43-
// A list of sub-tasks that the just computed task spawned.
4439
TaskSubmissions sub_tasks = 5;
4540
// A list of progress updates that the computed task wants to report.
4641
repeated Progress progress_updates = 4;
42+
43+
// A list of sub-tasks that the just computed task spawned. This field is deprecated and will be removed in the
44+
// future. Kept around for backwards compatibility.
45+
repeated SingleTaskSubmission legacy_sub_tasks = 3 [
46+
deprecated = true,
47+
// we support more than that due to grouping and tree spawning, but we rather want to encourage users
48+
// to update their clients to use the new field which has way less serialization overhead.
49+
(buf.validate.field).repeated.max_items = 1000
50+
];
4751
}
4852

4953
// IdlingResponse is set in the response of a NextTaskRequest if no task was returned, indicating that the requesting

0 commit comments

Comments
 (0)