Remove legtacy datasets api (#43)

Author: lukasbindreiter

apis/datasets/v1/core.proto

@@ -17,22 +17,11 @@ edition = "2023";
 package datasets.v1;
 
 import "datasets/v1/dataset_type.proto";
-// https://protobuf.dev/reference/protobuf/google.protobuf/#timestamp
-import "google/protobuf/timestamp.proto";
 import "tilebox/v1/id.proto";
 import "tilebox/v1/query.proto";
 
 option features.field_presence = IMPLICIT;
 
-// LegacyPagination - used for backwards compatibility, will be removed as soon as all datasets are migrated
-message LegacyPagination {
-  // The maximum number of entries to return.
-  int64 limit = 1 [features.field_presence = EXPLICIT];
-  // Return entries starting after this entry.
-  // This is the id of the last entry returned in the previous page as the next parameter in each paginated query.
-  string starting_after = 2 [features.field_presence = EXPLICIT];
-}
-
 // Any is a message that can hold any other message as bytes.
 // We don't use google.protobuf.Any because we want the JSON representation of the value field to be bytes.
 message Any {
@@ -53,39 +42,9 @@ message RepeatedAny {
  * Messages relevant for all Tilebox datasets
  */
 
-// DatapointMetadata contains the metadata for a single data point.
-// legacy, only relevant for old endpoints
-message DatapointMetadata {
-  // The time the message was received by the on-board computer.
-  google.protobuf.Timestamp event_time = 1;
-  // The time the message was ingested by Tilebox.
-  google.protobuf.Timestamp ingestion_time = 2;
-  // The external id of the datapoint.
-  string id = 3 [features.field_presence = EXPLICIT];
-}
-
-// DatapointPage is a single page of data points of a Tilebox dataset, such as it is returned by a ForInterval query
-message DatapointPage {
-  // A metadata for a datapoint.
-  repeated DatapointMetadata meta = 1;
-  // The datapoints.
-  RepeatedAny data = 2;
-  // The pagination parameters for the next page.
-  LegacyPagination next_page = 3 [features.field_presence = EXPLICIT];
-}
-
-// Datapoint is a single datapoint in a Tilebox Dataset
-message Datapoint {
-  // A metadata for a datapoint.
-  DatapointMetadata meta = 1;
-  // The data.
-  Any data = 2;
-}
-
 // Collection contains basic information about a dataset collection
 message Collection {
-  // Here for backwards compatibility, to be removed in the future.
-  string legacy_id = 1;
+  reserved 1; // was a
   string name = 2;
   tilebox.v1.ID id = 3;
 }

apis/datasets/v1/data_access.proto

@@ -12,39 +12,6 @@ import "tilebox/v1/query.proto";
 
 option features.field_presence = IMPLICIT;
 
-// Legacy message, to be removed in the future.
-// GetDatasetForIntervalRequest contains the request parameters for retrieving data for a time interval.
-message GetDatasetForIntervalRequest {
-  // The collection id.
-  string collection_id = 1;
-
-  // Either time interval or datapoint interval must be set, but not both.
-  // The time interval for which data is requested.
-  tilebox.v1.TimeInterval time_interval = 2;
-  // The datapoint interval for which data is requested.
-  tilebox.v1.IDInterval datapoint_interval = 6;
-
-  // The pagination parameters for this request.
-  LegacyPagination page = 3 [features.field_presence = EXPLICIT];
-  // If true, the datapoint data is not returned.
-  bool skip_data = 4;
-  // If true, the datapoint metadata is not returned.
-  // If both skip_data and skip_meta are true,
-  // the response will only consist of a list of datapoint ids without any additional data or metadata.
-  bool skip_meta = 5;
-}
-
-// Legacy message, to be removed in the future.
-// GetDatapointByIdRequest contains the request parameters for retrieving a single data point in a collection by its id.
-message GetDatapointByIdRequest {
-  // The collection id.
-  string collection_id = 1;
-  // The id of the requested data point.
-  string id = 2;
-  // If true, only the datapoint metadata is returned.
-  bool skip_data = 3;
-}
-
 // QueryByIDRequest contains the request parameters for retrieving a single data point by its id.
 message QueryByIDRequest {
   // The dataset id to query. If not set, the dataset is derived from the collection ids, in which case there must be at least one collection id set.
@@ -135,11 +102,6 @@ message QueryResultPage {
 
 // DataAccessService provides data access and querying capabilities for Tilebox datasets.
 service DataAccessService {
-  // legacy endpoint, kept around for backwards compatibility with older python clients for now
-  rpc GetDatasetForInterval(GetDatasetForIntervalRequest) returns (DatapointPage) {}
-  // legacy endpoint, kept around for backwards compatibility with older python clients for now
-  rpc GetDatapointByID(GetDatapointByIdRequest) returns (Datapoint) {}
-
   // QueryByID returns a single data point by its ID.
   rpc QueryByID(QueryByIDRequest) returns (Any) {}