Thunder General Discussion

[hjiangsu]

👋 Welcome!

We’re using Discussions as a place to connect with other members of our community. We hope that you:

• Ask questions you’re wondering about.
• Share ideas.
• Engage with other community members.
• Welcome others and are open-minded. Remember that this is a community we
  build together 💪.

[realeatham]

You should make a Lemmy community for this. Also check issues the android app can't access the internet

[hjiangsu]

Here's the lemmy community! I'll add this to the README as well for better discovery.

https://lemmy.world/c/thunder_app

[guigs4]

Hi,
Are you working on comment voting?
If not, I might create a PR soon to address this.

[jordan1776]

really slick, very minor thing, the colors on Lemmy for the votes are reversed from reddit (blue #007bff for up and dark orange #873208 from inspect element)

[hjiangsu]

hmm yeah, I've noticed that - I was wondering whether to keep it as the reddit's colours, or to switch over to lemmy's way. I was thinking initially to just keep it as the reddit colour so that it makes it less confusing for users who are transitioning from the reddit apps

however, i'm open to suggestions on what should be done!

[jordan1776]

The colors probably should be a setting in the theming with options for Lemmy, Reddit, and Kbin (green/red), To me, since it is a Lemmy app it should default to match Lemmy's colors. Maybe a OOBE, where when guiding through a user who first installs the app, ask "Are you new to Lemmy?" and if yes, use the Reddit colors?

[realeatham]

I think Instead of asking if they are new to Lemmy it could just ask what colors they want, and there should be a custom colors option (and a background color setting)

[hjiangsu]

The colors probably should be a setting in the theming with options for Lemmy, Reddit, and Kbin (green/red), To me, since it is a Lemmy app it should default to match Lemmy's colors.

Good idea, I think this is easy to implement and allows for some degree of customization - feel free to add this as an issue so that it can be tracked in the future!

[guigs4]

Aaaaaand it is done:

[hjiangsu]

awesome, that looks great!

[guigs4]

Also: partly solved issue #20, currently I only added the option to hide thumbnails

No previews of it working for obvious reasons

[hjiangsu]

thanks! is it okay if i assign you to that ticket for now? since its partially on the way?

[guigs4]

Sure thing!

[guigs4]

I will switch the behavior to match Apollo's and then start a PR.

Starting tomorrow I won't be able to reliably work on refining the feature for about a week or so.
Getting the PR out will allow for the feature to get out there for users and for developers to further refine in case I can't get to it in a timely manner.

[hjiangsu]

Thats alright! Any help is better than no help 😄 Are you able to leave a comment on #20 so that I can assign the ticket to you for the meantime?

[shortwavesurfer2009]

I think Thunder should load more posts at once. I generally like "subscribed" and "new" for my defaults but this causes quite a bit of scrolling and loading after a while away. Sleep for 6-8 hours and then scroll to the posts you have already read. It takes a bit. I think maybe loading 50 at once instead of like 15.

[guigs4]

About #126:
Already have it working but it involved manually altering the lemmy_api_client library, It's a small change, just had to add a couple of entries to SortType (enums.dart).
Problem is: this obviously means it'll break should anyone try to use it.
I thought about opening an issue on liftoff-app/lemmy_api_client but they don't seem to have an 'issues' page.
I'll try to open a PR to address this over there.

Just letting y'all know.

[Tealk]

Wouldn't it be better if the feature requests were posted here, then they could be voted up and down.

[hjiangsu]

I think for feature requests, its okay to have them as issues on GitHub, but then have people vote on them by giving thumbs up for features that they feel like are more important

This way, I (and others in the community) can easily sort by those issues and place a greater focus on them

Thoughts on this?

[Tealk]

Ah ok I have not noticed until now that you can also sort issues by votes, then I have said nothing 😅

But then it might make sense to remove this category, otherwise the ideas/features end up splitting into issues and discussions.

[Tealk]

Another idea would be a chat like Matrix, then you could talk a little bit about it before the bug report and maybe improve the reports?

[CTalvio]

Just found the matrix space, its a great way to organize some meta-discussions on the work going into the app.

Are there any rooms yet? It errored out after I joined and isn't loading any.

[hjiangsu]

There should be some rooms set up already! What's the error you're getting?

[CTalvio]

Simply "Failed to load list of rooms." But good to know its not supposed to be empty.

Probably down to something being up with my matrix instance. I'll say hi in matrix once I figure it out.

[Poolitzer]

looking forward to it

[Tealk]

@hjiangsu Are the rooms public?

To find them more easily you can select the following: