Repository navigation
Commit d820e8f
authored
* ✂️ Make xmd plan produce approved XMD source only
`xmd plan` mapped one request to a reviewed program and could then run it.
Two responsibilities in one command meant a caller who wanted the program
kept had to remember which flags configured which half, and a caller who
only wanted source still paid for a grammar describing an execution.
It now produces the artifact and stops. One invocation executes exactly one
root — the packaged plan command document — awaits its complete teardown,
structurally revalidates the returned bytes, and delivers them to stdout or
to an exclusively created `--output` path. Whether that program runs is the
caller's composition: `xmd plan … | xmd run -`, or a saved artifact a later
`xmd run` names.
The execution capability is gone structurally rather than left unselected:
`PlanCommand.run`, `PlanExecution`, `PlanExecutionConfig`, the
`PlanDependencies.execute` callback, `planExecutor`, the final
`retainedSource("<plan>")` run, and the command-side property binding,
signature freezing and reserved-token plumbing all had no consumer left.
The final host gate stays, and is now structural — the same contract
`<AdmitPlan>` applies — so a Plan declaring required root props is admitted
rather than refused for arguments nobody has offered it yet.
The grammar keeps one request, `--include`, `--agent-provider`,
`--default-agent`, `--session`, `--timeout`, `--output`, and ordinary help
and version. Every option that configured the former execution is refused by
name in fixed preflight, before the general parser can drop or coerce a
token: `--run` reports the migration naming both compositions, and each of
the rest reports that `xmd run` is where a program is configured. Authorship
now settles a provider and a default agent and no permission mode at all.
The same options are unchanged under `xmd run`.
* ✂️ Correct the Plan gates, help preflight and property recognition
Four blockers from the #724 feedback review.
The command validated approved bytes twice, but nothing could tell the two
apart: `<AdmitPlan>` and the host's gate reached the same conclusion from
separately built inputs, so the C10 that removed a component during teardown
was answered by the first of them and deleting the second left every suite
green. The invocation now settles one structural check — `validateDocumentStructure`
under the ordinary run-profile registry, the `<plan>` identity, the caller's
includes and the run profile's declarations — and hands that one to
`<CheckDraft>`, to `<AdmitPlan>` and to itself. What the three can disagree
about is when it was asked, which is the whole point of keeping the last one:
C10 and PS9 now let both Component gates really validate and succeed, move the
tree immediately after that admission, and watch the host refuse. Deleting the
host's gate fails both.
`AuthorshipProfile.installElicitation` and `.assess` had no consumer and are
gone; the dependencies `planComponentDeclaration` captures are unchanged.
`--help` is lifted out of argv before any command's own grammar runs, so
`xmd plan --help --run` printed a page describing a command that would have
refused the caller. A shared pure `removedPlanOption()` — the same
classification the scan uses — answers first, in either order. Help that names
no removed option is still the exact approved help.
Generated-property recognition was a prefix test, so `--propspective`,
`--no-propspective` and a bare `--no-props` were told to configure their
program with `xmd run`. It is now exactly `--props`, `--props-*` and
`--no-props-*`; everything else keeps the generic unknown-option refusal.
The three session-directory diagnostics are restored to their base wording —
they were never part of the approved source-only copy. Stale prose that still
had an approved Plan running or receiving the ordinary run stack is corrected
in `agent-stack.ts`, the repository-provider comment in `cli.ts`, and
`plan.test.ts`.
* 🐛 Fix the Node typecheck and the site format check
Two CI-only failures, both from checks that do not run in `deno task check`.
`tsconfig.node.json` targets ES2022 and Deno's own lib is newer, so
`Object.keys(scan).toSorted()` passed locally and failed all seven `test-node`
shards with TS2550. The assertion is about which fields the scan established,
not about their order, so it compares the two directions of set membership
instead of sorting — `unicorn(no-array-sort)` would only have suggested
`toSorted` back.
`site/` runs its own `deno task check`, which begins with `deno fmt --check`;
`oxfmt` formats `packages/` and never saw the homepage paragraph. Reflowed by
`deno fmt`, leaving the sentence PS12 pins on one line.
1 parent 6fdad88 commit d820e8f
29 files changed
Lines changed: 1966 additions & 2562 deletions
File tree
- packages/cli
- src
- documents
- tests
- support
- scripts/tests
- site/routes
- specs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
74 | 85 | | |
75 | 86 | | |
76 | 87 | | |
| |||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
16 | 21 | | |
17 | 22 | | |
18 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
| 2 | + | |
| 3 | + | |
4 | 4 | | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
55 | 62 | | |
56 | 63 | | |
57 | 64 | | |
58 | 65 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
72 | 77 | | |
73 | | - | |
74 | | - | |
| 78 | + | |
| 79 | + | |
75 | 80 | | |
76 | 81 | | |
77 | 82 | | |
78 | | - | |
| 83 | + | |
79 | 84 | | |
80 | | - | |
81 | | - | |
| 85 | + | |
| 86 | + | |
82 | 87 | | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
| 88 | + | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
91 | 92 | | |
92 | | - | |
| 93 | + | |
93 | 94 | | |
94 | 95 | | |
95 | 96 | | |
96 | | - | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
102 | 124 | | |
103 | 125 | | |
104 | 126 | | |
| |||
112 | 134 | | |
113 | 135 | | |
114 | 136 | | |
115 | | - | |
| 137 | + | |
116 | 138 | | |
117 | 139 | | |
118 | 140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | 111 | | |
114 | 112 | | |
115 | 113 | | |
| |||
119 | 117 | | |
120 | 118 | | |
121 | 119 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | 120 | | |
132 | 121 | | |
133 | 122 | | |
134 | 123 | | |
135 | | - | |
| 124 | + | |
136 | 125 | | |
137 | 126 | | |
138 | 127 | | |
| |||
145 | 134 | | |
146 | 135 | | |
147 | 136 | | |
148 | | - | |
149 | | - | |
150 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
151 | 140 | | |
152 | 141 | | |
153 | 142 | | |
| |||
222 | 211 | | |
223 | 212 | | |
224 | 213 | | |
225 | | - | |
| 214 | + | |
226 | 215 | | |
227 | 216 | | |
228 | 217 | | |
| |||
359 | 348 | | |
360 | 349 | | |
361 | 350 | | |
362 | | - | |
| 351 | + | |
363 | 352 | | |
364 | 353 | | |
365 | 354 | | |
| |||
644 | 633 | | |
645 | 634 | | |
646 | 635 | | |
647 | | - | |
| 636 | + | |
648 | 637 | | |
649 | 638 | | |
650 | 639 | | |
| |||
0 commit comments