Test REPL behavior through terminal page objects (#1016)

Author: taras

.github/workflows/ci.yml

@@ -88,11 +88,11 @@ jobs:
   # an artifact-and-dependency boundary between jobs that #279 spent its length
   # removing.
   test-deno:
-    name: test-deno (${{ matrix.shard }}/15)
+    name: test-deno (${{ matrix.shard }}/19)
     strategy:
       fail-fast: false
       matrix:
-        shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15]
+        shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
@@ -127,7 +127,7 @@ jobs:
         run: deno task build:web
 
       - name: Test
-        run: deno run --allow-all --frozen scripts/runtime-tests.ts deno ${{ matrix.shard }}/15
+        run: deno run --allow-all --frozen scripts/runtime-tests.ts deno ${{ matrix.shard }}/19
 
   # The same command the release publishes with, minus --dry-run. Catches slow
   # types and unresolvable specifiers before they reach a tag.
@@ -604,11 +604,11 @@ jobs:
         working-directory: site
 
   test-node:
-    name: test-node (${{ matrix.shard }}/10)
+    name: test-node (${{ matrix.shard }}/16)
     strategy:
       fail-fast: false
       matrix:
-        shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+        shard: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
@@ -646,14 +646,14 @@ jobs:
         run: pnpm exec tsc --project tsconfig.node.json --noEmit
 
       - name: Test
-        run: pnpm test:node ${{ matrix.shard }}/10
+        run: pnpm test:node ${{ matrix.shard }}/16
 
   test-bun:
-    name: test-bun (${{ matrix.shard }}/5)
+    name: test-bun (${{ matrix.shard }}/9)
     strategy:
       fail-fast: false
       matrix:
-        shard: [1, 2, 3, 4, 5]
+        shard: [1, 2, 3, 4, 5, 6, 7, 8, 9]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
@@ -669,7 +669,7 @@ jobs:
       - run: bun install
 
       - name: Test
-        run: bun run test:bun ${{ matrix.shard }}/5
+        run: bun run test:bun ${{ matrix.shard }}/9
 
       # test:bun never loads packages/cli/src/bun.ts, so it cannot tell whether
       # the Bun entrypoint's API.Env providers work. This document drives a

packages/cli/src/repl/layout.ts

@@ -210,9 +210,6 @@ const WIDE: ReplTerminalSize = { columns: 160, rows: 36 };
  * it offers changes while the two rows around it do not.
  */
 export const FOOTER_ROWS = 7;
-/** The History band's own five rows. */
-export { HISTORY_ROWS } from "./history-rail.ts";
-
 /** Five, at every size — imported for this module's own layout. */
 import { HISTORY_ROWS } from "./history-rail.ts";
 
@@ -470,11 +467,6 @@ export function rowProps(width: number | undefined): ReplBoxProps {
   };
 }
 
-/** One row of a region whose width is not yet known. */
-export const ROW_PROPS: ReplBoxProps = Object.freeze({
-  layout: Object.freeze({ width: grow(), height: fixed(1) }),
-});
-
 /** A control of the action row: as wide as its own label. */
 export const CONTROL_PROPS: ReplBoxProps = Object.freeze({
   layout: Object.freeze({ width: fit(), height: fixed(1) }),