Skip to content

Commit 137f3b3

Browse files
committed
🚨 Classify the Q7 distribution harness as Deno's own (#934)
Discovery finds every `scripts/tests/*.test.ts` and hands it to all three runtimes unless the manifest says otherwise, so the new packaging harness was being scheduled under Node and Bun — where `Deno.execPath()`, the canonical host compile and the dnt closure build have no meaning. Classifying it is the act that file was missing. Nothing it proves is dropped. The Node and Bun consumers are the ones this harness launches: source Node through the repository's `tsx` loader, source Bun, and the packed closure under both. Excluding the driver from those runtimes leaves every one of those launches exactly where it was, and what the engine does inside a document stays proven on every runtime by `query-component.test.ts`. One entry, in the list the adjacent Deno build and npm tooling already use, under the issue the manifest keeps that decision in. Discovery, the runners, the harness, its assertions and `exclusions.deno` are untouched.
1 parent b9a49ba commit 137f3b3

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎scripts/runtime-test-exclusions.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,12 @@ const DENO_ONLY_TOOLING: RuntimeExclusion[] = [
7171
"builds packages/acp with dnt before driving the artifact under Node, and that build is spawned as `<execPath> run -A scripts/build-npm.ts` — an argument vector only the Deno CLI understands; the materialization it then proves is covered portably by Tier AM",
7272
issue: DERIVED_SCOPE,
7373
},
74+
{
75+
path: "scripts/tests/query-distribution.test.ts",
76+
reason:
77+
"it is the harness that drives the query engine into every distribution, and the driving is Deno's own: it starts `Deno.execPath()` for the source arm, compiles the host binary through the canonical `compile()`, and builds the CLI's npm closure with dnt before packing and installing it. The Node and Bun consumers it exists to prove are launched by it — source Node through the repository's `tsx` loader, source Bun, and the packed closure under both — so excluding the harness from those runtimes drops none of that consumption. What the engine does inside a document is proven on every runtime by packages/core/tests/query-component.test.ts",
78+
issue: DERIVED_SCOPE,
79+
},
7480
{
7581
path: "scripts/tests/cloudflare-dofs-vendor.test.ts",
7682
reason:

0 commit comments

Comments
 (0)