From 6b2a8ebf8a84e54b81b9631d154134cfbac3ad7e Mon Sep 17 00:00:00 2001 From: nuclearmayhem1 <53118215+nuclearmayhem1@users.noreply.github.com> Date: Tue, 13 Jan 2026 13:33:35 +0100 Subject: [PATCH] Fixed crash caused by missing nullcheck May be some underlying issues still I am not familiar with the codebase. --- src/main/java/com/talhanation/recruits/world/RecruitsClaim.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/talhanation/recruits/world/RecruitsClaim.java b/src/main/java/com/talhanation/recruits/world/RecruitsClaim.java index f27813d8f..a99ba07f4 100644 --- a/src/main/java/com/talhanation/recruits/world/RecruitsClaim.java +++ b/src/main/java/com/talhanation/recruits/world/RecruitsClaim.java @@ -358,6 +358,7 @@ private void notifyAttackersSiegeFailed(ServerLevel level) { public void addParty(List list, RecruitsFaction recruitsFaction) { if(list.isEmpty()) return; + if(recruitsFaction == null) return; for(RecruitsFaction attacker : list){ if(attacker != null && attacker.getStringID().equals(recruitsFaction.getStringID())) return; } @@ -365,7 +366,6 @@ public void addParty(List list, RecruitsFaction recruitsFaction list.add(recruitsFaction); } - private List getAttackingParties() { return attackingParties == null ? Collections.emptyList() : attackingParties; }