Repository navigation
Commit e2178d4
committed
fix(fleet): scope the sweep duplicate-check to the paths this round touched
Follow-up to #691. Measured 2026-08-11 in production: PR #692 duplicated
#690 (byte-identical diffs, md5-verified) -- the #691 fix's own
full-tree comparison missed it, because #690's branch was cut BEFORE
#691 itself landed on origin/main, so it legitimately lacks the
scripts/ changes #691 added. #692's branch, cut after #691 merged,
carries those changes. A raw `diff --quiet <candidate>..HEAD` sees
that unrelated drift as "different" and can never again match #690,
no matter how many more times the same tag gap gets re-solved
identically -- and the same defeat recurs for every future round
whenever ANY unrelated commit lands on main while a sweep PR sits
open, which given "the fleet publishes, it never merges" is routine.
Fix: scope the comparison to `git diff --name-only origin_ref..HEAD`
-- the paths THIS round's own squad merges actually touched -- instead
of a full-tree diff. That isolates the tag-fix content from incidental
history the two branches don't share.
New regression test reproduces the exact #692-vs-#690 shape: an
unrelated commit lands on main between when the open PR's branch was
cut and when the new round's branch is cut, with the identical tag fix
on both. Confirmed the test fails against the unversioned (pre-fix)
code and passes with it. Full suite: 102 + 240 tests green.1 parent ccd14f3 commit e2178d4
2 files changed
Lines changed: 81 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1691 | 1691 | | |
1692 | 1692 | | |
1693 | 1693 | | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
1694 | 1707 | | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
1695 | 1711 | | |
1696 | 1712 | | |
1697 | 1713 | | |
| |||
1703 | 1719 | | |
1704 | 1720 | | |
1705 | 1721 | | |
1706 | | - | |
| 1722 | + | |
1707 | 1723 | | |
1708 | 1724 | | |
1709 | 1725 | | |
| |||
1716 | 1732 | | |
1717 | 1733 | | |
1718 | 1734 | | |
1719 | | - | |
| 1735 | + | |
| 1736 | + | |
1720 | 1737 | | |
1721 | 1738 | | |
1722 | 1739 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1701 | 1701 | | |
1702 | 1702 | | |
1703 | 1703 | | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
| 1747 | + | |
| 1748 | + | |
| 1749 | + | |
| 1750 | + | |
| 1751 | + | |
| 1752 | + | |
| 1753 | + | |
| 1754 | + | |
| 1755 | + | |
| 1756 | + | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
1704 | 1766 | | |
1705 | 1767 | | |
1706 | 1768 | | |
| |||
0 commit comments