[BUG] FBNS MQTT Timeout on read causes a disconnection

[qwer-lives]

What broke?

This is a consequence the fix for #396. It is now marking connected = False for all exceptions on fbns._recv_packet. However, it is natural to sometimes receive a timeout when trying to read, for example if not pinging often enough. This shouldn't disconnect the fbns client as the socket is still open.

Also, a bit tangential but the keep-alive is hardcoded to 60 seconds on connection and the socket timeout to 30 seconds. Should the socket timeout be higher than the MQTT keep alive? This also means I have to ping really often if I want to avoid timeouts (<30s). I wonder if these timings have been obtained experimentally and whether Instagram will really complain even if the client is not that aggressive? Could we maybe make these parameters configurable on connection?

Affected area

realtime

Minimal reproduction code

cl = Client()
// init client
await cl.fbns_connect()
try:
    await cl.fbns_read_once()
except Exception as e:
    print(f"Got exception {e}, connected={cl.fbns.connected}")

Full traceback

No traceback

Observed result

FBNS client is marked as disconnected on read timeout.

Expected result

FBNS client should stay connected, and only be marked as disconnected when the socket is actually closed.

aiograpi version

1.12.0

Python version

3.14.6

Operating system

7.0.12-1-cachyos

Login method

username/password

Proxy in use

no proxy

Can you reproduce on current main?

yes

Raw API response or payload sample

Additional context

No response

[subzeroid]

Thanks for the report. Confirmed as a regression from the FBNS cleanup change.

Root cause: FbnsClient._recv_packet() was marking the client disconnected for every read exception. A socket read TimeoutError can simply mean no MQTT packet arrived before the read timeout; it does not prove the socket is closed.

Fix PRs:

• aiograpi: Keep FBNS connected on read timeout #403
• instagrapi mirror: Keep FBNS connected on read timeout instagrapi#2717

The fix keeps connected=True for read timeouts while preserving the existing behavior where closed sockets / transport failures mark FBNS disconnected.

Verification run locally:

• RED regression test failed before the fix with fbns.connected false after TimeoutError
• aiograpi: ruff check aiograpi/realtime/fbns.py tests/regression/test_fbns.py
• aiograpi: pytest -q tests/regression/test_fbns.py
• aiograpi: pytest -q tests/regression
• instagrapi: ruff check instagrapi/realtime/fbns.py tests/regression/test_fbns.py
• instagrapi: pytest -q tests/regression/test_fbns.py
• instagrapi: pytest -q tests/regression

[subzeroid]

Released now.

• aiograpi 1.12.1: https://github.com/subzeroid/aiograpi/releases/tag/1.12.1 / https://pypi.org/project/aiograpi/1.12.1/
• instagrapi 2.18.1: https://github.com/subzeroid/instagrapi/releases/tag/2.18.1 / https://pypi.org/project/instagrapi/2.18.1/

This keeps FBNS connected on read TimeoutError while preserving disconnected state for closed sockets and transport failures. Regression coverage was added in both repositories.