Return newBlock instead of duplicate from ProcessBlock

Rename the ProcessBlock return value from duplicate to newBlock to align with the C API parameter naming.

Author: stringintech

kernel/chainstate_manager.go

@@ -118,14 +118,14 @@ func (cm *ChainstateManager) ReadBlockSpentOutputs(blockTreeEntry *BlockTreeEntr
 //   - block: Block to validate and potentially add to the chain
 //
 // Returns ok=true if processing the block was successful (will also return true for valid,
-// but duplicate blocks) and duplicate=false if this block was not processed before. Note that
-// duplicate might also be false if processing was attempted before, but the block was found
+// but duplicate blocks) and newBlock=true if this block was not processed before. Note that
+// newBlock might also be true if processing was attempted before, but the block was found
 // invalid before its data was persisted.
-func (cm *ChainstateManager) ProcessBlock(block *Block) (ok bool, duplicate bool) {
-	var newBlock C.int
-	result := C.btck_chainstate_manager_process_block((*C.btck_ChainstateManager)(cm.ptr), (*C.btck_Block)(block.ptr), &newBlock)
+func (cm *ChainstateManager) ProcessBlock(block *Block) (ok bool, newBlock bool) {
+	var newBlockInt C.int
+	result := C.btck_chainstate_manager_process_block((*C.btck_ChainstateManager)(cm.ptr), (*C.btck_Block)(block.ptr), &newBlockInt)
 	ok = result == 0
-	duplicate = newBlock == 0
+	newBlock = newBlockInt == 1
 	return
 }
 

kernel/chainstate_manager_test.go

@@ -317,10 +317,13 @@ func (s *ChainstateManagerTestSuite) Setup(t *testing.T) {
 		}
 		defer block.Destroy()
 
-		ok, duplicate := manager.ProcessBlock(block)
-		if !ok || duplicate {
+		ok, newBlock := manager.ProcessBlock(block)
+		if !ok {
 			t.Fatalf("ProcessBlock() failed for block %d", i+1)
 		}
+		if !newBlock {
+			t.Fatalf("ProcessBlock() returned newBlock=false for block %d (block data was already on disk)", i+1)
+		}
 	}
 
 	s.Manager = manager