Description

Currently SignalClient has a complex system of caching received signals:

In most cases, we expect signals in response to some RPC. And sometimes the signal is received while we are still processing the blocking RPC.

Therefore we mix 2 approaches in tests:

• waiting for a signal after making an action
• prepare for signal before the action and check it after the action

And this makes the code very complicated (yet not super reliable).

Proposal

Refactor the thing. SImplify it.

Use with

I would love to see us using with here, smth like this:

def test_foo(backend_new_profile):
    sender = backend_new_profile()
    receiver = backend_new_profile()

    with receiver.expect_signal(SignalType.MESSAGES_NEW, timeout=30):
        message_text = "Hello, World!"
        sender.wakuext_service.send_one_to_one_message(receiver.public_key, message_text)

Though I'm not sure if it will be usable in all cases, we should analyze this carefully first.