From d321c38f48fea838e58057183566fbdb11723c4b Mon Sep 17 00:00:00 2001 From: Lucas Miranda Date: Thu, 21 May 2026 18:27:50 -0300 Subject: [PATCH 1/2] Fix stale integration test fixtures --- CHANGELOG.md | 2 ++ test/core_clojure/rest_test.clj | 63 +++++++++++++++++---------------- 2 files changed, 35 insertions(+), 30 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 265a7eb..951d235 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,8 @@ Given a version number MAJOR.MINOR.PATCH, increment: - PATCH version when backwards compatible bug **fixes** are implemented. ## [Unreleased] +### Fixed +- integration test fixtures for rest-post, rest-post-single, and rest-post-sub-resource ## [0.2.0] - 2024-09-16 ### Added diff --git a/test/core_clojure/rest_test.clj b/test/core_clojure/rest_test.clj index 20e30a7..78b3a7b 100644 --- a/test/core_clojure/rest_test.clj +++ b/test/core_clojure/rest_test.clj @@ -94,19 +94,21 @@ (deftest rest-post (testing "post method " - (let [invoices {:amount 400000} - corporate-invoice (rest/post - "bank" - "0.0.0" - (user) - "corporate-invoice" - invoices - "" - "v2" - "en-US" - 15)] - (is (int? - (:amount (:invoice corporate-invoice))))))) + (let [webhook-url (str "https://webhook.site/" (java.util.UUID/randomUUID)) + payload {:url webhook-url :subscriptions ["transfer"]} + response (rest/post + "bank" + "0.0.0" + (user) + "webhook" + payload + "" + "v2" + "en-US" + 15) + webhook (:webhook response)] + (rest/delete-id "bank" "0.0.0" (user) "webhook" (:id webhook) "v2" "en-US" 15) + (is (= webhook-url (:url webhook)))))) (deftest rest-post-multi (testing "post multi method " @@ -131,19 +133,20 @@ (deftest rest-post-single (testing "post single method " - (let [invoices {:amount 400000} - corporate-invoice (rest/post-single - "bank" - "0.0.0" - (user) - "corporate-invoice" - invoices - "" - "v2" - "en-US" - 15)] - (is (int? - (:amount corporate-invoice)))))) + (let [webhook-url (str "https://webhook.site/" (java.util.UUID/randomUUID)) + payload {:url webhook-url :subscriptions ["transfer"]} + webhook (rest/post-single + "bank" + "0.0.0" + (user) + "webhook" + payload + "" + "v2" + "en-US" + 15)] + (rest/delete-id "bank" "0.0.0" (user) "webhook" (:id webhook) "v2" "en-US" 15) + (is (= webhook-url (:url webhook)))))) (deftest rest-post-sub-resource (testing "post sub resource method " @@ -153,9 +156,9 @@ (user) "merchant-session" {:allowedFundingTypes ["debit" "credit"] - :allowedInstallments [{:totalAmount 0 :count 1} - {:totalAmount 120 :count 2} - {:totalAmount 180 :count 12}] + :allowedInstallments [{:totalAmount 500 :count 1} + {:totalAmount 1000 :count 2} + {:totalAmount 6000 :count 12}] :expiration 3600 :challengeMode "disabled" :tags ["yourTags"]} @@ -164,7 +167,7 @@ "en-US" 15)) merchant-session { - :amount 180 + :amount 6000 :installmentCount 12 :cardExpiration "2035-01" :cardNumber "5277696455399733" From 945c46d8fbe97527c86517431110e40cc3b3724a Mon Sep 17 00:00:00 2001 From: Lucas Miranda Date: Thu, 21 May 2026 18:46:34 -0300 Subject: [PATCH 2/2] Change post tests to increase test coverage --- test/core_clojure/rest_test.clj | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/test/core_clojure/rest_test.clj b/test/core_clojure/rest_test.clj index 78b3a7b..7b6e87c 100644 --- a/test/core_clojure/rest_test.clj +++ b/test/core_clojure/rest_test.clj @@ -94,21 +94,20 @@ (deftest rest-post (testing "post method " - (let [webhook-url (str "https://webhook.site/" (java.util.UUID/randomUUID)) - payload {:url webhook-url :subscriptions ["transfer"]} + (let [payload {:invoices [{:amount 100 + :name "Iron Bank S.A." + :taxId "20.018.183/0001-80"}]} response (rest/post "bank" "0.0.0" (user) - "webhook" + "invoice" payload "" "v2" "en-US" - 15) - webhook (:webhook response)] - (rest/delete-id "bank" "0.0.0" (user) "webhook" (:id webhook) "v2" "en-US" 15) - (is (= webhook-url (:url webhook)))))) + 15)] + (is (= 100 (:amount (first (:invoices response)))))))) (deftest rest-post-multi (testing "post multi method " @@ -134,7 +133,7 @@ (deftest rest-post-single (testing "post single method " (let [webhook-url (str "https://webhook.site/" (java.util.UUID/randomUUID)) - payload {:url webhook-url :subscriptions ["transfer"]} + payload {:url webhook-url :subscriptions ["transfer" "boleto-payment"]} webhook (rest/post-single "bank" "0.0.0" @@ -145,8 +144,15 @@ "v2" "en-US" 15)] + (is (string? (:url webhook))) + (is (= webhook-url (:url webhook))) (rest/delete-id "bank" "0.0.0" (user) "webhook" (:id webhook) "v2" "en-US" 15) - (is (= webhook-url (:url webhook)))))) + (try + (rest/get-id "bank" "0.0.0" (user) "webhook" (:id webhook) {} "v2" "en-US" 15) + (is false "Webhook still exists after delete") + (catch clojure.lang.ExceptionInfo e + (is (= "invalidWebhookId" + (:code (first (:errors (ex-data e))))))))))) (deftest rest-post-sub-resource (testing "post sub resource method "