Merge pull request #160 from erizocosmico/fix/bitbucket-provider-checkpoint

fix how the last checkpoint of bitbucket provider is obtained

Author: ajnavarro

providers/bitbucket/provider.go

@@ -48,7 +48,7 @@ func (p *provider) needsMoreData() bool {
 func (p *provider) initializeCheckpoint() error {
 	result, err := p.repositoryStore.FindOne(
 		model.NewRepositoryQuery().
-			Order(kallax.Asc(model.Schema.Repository.CreatedAt)),
+			Order(kallax.Desc(model.Schema.Repository.CreatedAt)),
 	)
 
 	switch err {

providers/bitbucket/provider_test.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"io"
 	"testing"
+	"time"
 
 	"github.com/src-d/rovers/core"
 	"github.com/src-d/rovers/providers/bitbucket/model"
@@ -108,3 +109,26 @@ func (s *ProviderSuite) TestProvider_NextAckNext(c *C) {
 	c.Assert(err, IsNil)
 	c.Assert(r, Not(DeepEquals), r2)
 }
+
+func (s *ProviderSuite) TestInitializeCheckpoint(c *C) {
+	p := NewProvider(s.DB).(*provider)
+	c.Assert(p.initializeCheckpoint(), IsNil)
+	c.Assert("", Equals, p.lastCheckpoint)
+
+	now := time.Now()
+	c.Assert(p.repositoryStore.Insert(mkRepo(now.Add(-1*time.Hour), "1")), IsNil)
+	c.Assert(p.repositoryStore.Insert(mkRepo(now.Add(-1*time.Minute), "2")), IsNil)
+
+	c.Assert(p.initializeCheckpoint(), IsNil)
+	c.Assert("2", Equals, p.lastCheckpoint)
+}
+
+func mkRepo(createdAt time.Time, next string) *model.Repository {
+	r := &model.Repository{
+		ID:   kallax.NewULID(),
+		Next: next,
+	}
+
+	r.CreatedAt = createdAt
+	return r
+}

providers/bitbucket/replayer.go

@@ -10,9 +10,8 @@ import (
 )
 
 type replayer struct {
-	store         *model.RepositoryStore
-	rs            *model.RepositoryResultSet
-	isInitialized bool
+	store *model.RepositoryStore
+	rs    *model.RepositoryResultSet
 }
 
 func NewReplayer(db *sql.DB) core.RepoProvider {
@@ -52,5 +51,5 @@ func (r *replayer) Close() error {
 }
 
 func (r *replayer) Name() string {
-	return core.GithubProviderName
+	return core.BitbucketProviderName
 }