Skip to content

feat: improve data export destination graph - #6073

Merged
tgmendes merged 3 commits into
mainfrom
fix-data-export-destination-ui
Sep 4, 2026
Merged

feat: improve data export destination graph#6073
tgmendes merged 3 commits into
mainfrom
fix-data-export-destination-ui

Conversation

@tgmendes

@tgmendes tgmendes commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Group export routes by destination so shared collectors render once with converging connections.
  • Make source and destination nodes clickable, and add a destination editor for names, OTLP endpoints, headers, and sensitive-data policy.
  • Preserve stored write-only header values during edits and clarify the export-enabled helper text.
  • Add focused coverage for grouping, node interactions, and destination editing.

Motivation

The export graph duplicated collectors when multiple data sources sent to the same destination. Destinations also had no direct editing path, which forced users to recreate configuration instead of maintaining the shared collector in place.


Summary by cubic

Groups export routes by destination so a shared collector renders once with converging connections, and makes source and destination nodes clickable with a new destination editor. Previously each route rendered its own destination node and destinations had no in-place editing path.

Details

  • Tightens endpoint validation to reject query strings, fragments, userinfo, control characters, and non-HTTP(S) URLs.
  • Validates header names as HTTP tokens and rejects control characters in header values.
  • Clicking a source node opens the existing export configuration sheet.
  • Clicking a destination node opens a new sheet for editing name, OTLP endpoint, headers, and sensitive-data policy.
  • Write-only header values stay preserved on edit and are never displayed back in the form.
  • The enable toggle helper text now says data starts exporting as soon as you save.
  • Adds unit tests for destination grouping, node interactions, destination editing, and the new validation rules.

Written for commit a7c09fb. Summary will update on new commits.

Review in cubic

@tgmendes
tgmendes requested review from a team as code owners September 4, 2026 10:48
@tgmendes tgmendes added enhancement New feature or request javascript Pull requests that update javascript code labels Sep 4, 2026
@changeset-bot

changeset-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a7c09fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Running ultrareview automatically — This PR introduces a new destination editor with write-only header handling, grouping logic, and a large UI refactor. Bugs here could leak stored header values or corrupt destination configuration, warranting a deep multi-pass review.. I'll post findings when complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultrareview completed in 7m 21s

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread client/dashboard/src/pages/data-exports/ConfigureDestinationSheet.tsx Outdated
Comment thread client/dashboard/src/pages/data-exports/ConfigureDestinationSheet.tsx Outdated
Comment thread client/dashboard/src/pages/data-exports/ConfigureDestinationSheet.tsx Outdated
@tgmendes

tgmendes commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Demo

Data export destination graph demo

What it shows:

  1. Multiple data sources converge on one shared destination node.
  2. Clicking a source card opens its route configuration.
  3. Clicking the destination card opens the shared destination editor; saving updates the graph.

Fictional sample data.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Comment thread client/dashboard/src/lib/data-export-validation.ts
Comment thread client/dashboard/src/lib/data-export-validation.ts
@tgmendes
tgmendes added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 9cca3df Sep 4, 2026
58 checks passed
@tgmendes
tgmendes deleted the fix-data-export-destination-ui branch September 4, 2026 12:41
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants