Fire breath sound effect plays incorrectly

[musicguy423]

Describe your bug here. And how to reproduce it.

Fire breath sound effect's noise pitch is too high. It's supposed to play at a much lower pitch.

What is your build target?

Windows

[HoRnEyDvL]

Describe your bug here. And how to reproduce it.

Fire breath sound effect's noise pitch is too high. It's supposed to play at a much lower pitch.

What is your build target?

Windows

---

The Sfx3_Process 0xDA instrument handler enables the noise channel by writing to the DSP FLG register. The bytes in the sound data (like 0x91, 0x8C, 0x8D) are noise-enable flags that also encode the desired noise clock rate in their lower 5 bits. The code was hardcoding FLG = 0x1F (rate 31 = max frequency = 32000 Hz) instead of using cmd & 0x1F from the actual data byte. Sound 23 wanted rate 17 = ~667 Hz — roughly 48× lower than what was playing.
Affected sounds: 23, 24, 25, 26, 31, 38 — all the fire/whoosh sounds that use the noise tail on sfx channel 3.

In File SMW_SPC_PLAYER.C Around lines 635 & 636

Change these 2 lines

p->sfx3_unused = 0x1f;
Dsp_Write(p, FLG, 0x1f);

To this

p->sfx3_unused = cmd & 0x1f;
Dsp_Write(p, FLG, cmd & 0x1f); // noise rate encoded in lower 5 bits of data byte