From 1b9aeafbabf6c84e6917756d01822c71059313e8 Mon Sep 17 00:00:00 2001 From: Pavlos Tzianos Date: Mon, 17 Nov 2025 17:50:55 +0000 Subject: [PATCH] remove unused environment variable from sobelow scanner --- .../internal/transformer/transformer.go | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/components/scanners/sobelow/internal/transformer/transformer.go b/components/scanners/sobelow/internal/transformer/transformer.go index 8e540940b..c4f3ce6ac 100644 --- a/components/scanners/sobelow/internal/transformer/transformer.go +++ b/components/scanners/sobelow/internal/transformer/transformer.go @@ -17,8 +17,6 @@ import ( componentlogger "github.com/smithy-security/smithy/sdk/logger" ) -const TargetTypeRepository TargetType = "repository" - type ( // SobelowTransformerOption allows customising the transformer. SobelowTransformerOption func(g *sobelowTransformer) error @@ -27,7 +25,6 @@ type ( TargetType string sobelowTransformer struct { - targetType TargetType clock clockwork.Clock resultsDirPath string workspacePath string @@ -49,17 +46,6 @@ func SobelowTransformerWithClock(clock clockwork.Clock) SobelowTransformerOption } } -// SobelowTransformerWithTarget allows customising the underlying target type. -func SobelowTransformerWithTarget(target TargetType) SobelowTransformerOption { - return func(g *sobelowTransformer) error { - if target == "" { - return errors.Errorf("invalid empty target") - } - g.targetType = target - return nil - } -} - // SobelowResultsDirPath allows customising the results directory path func SobelowResultsDirPath(path string) SobelowTransformerOption { return func(g *sobelowTransformer) error { @@ -82,15 +68,6 @@ func New(opts ...SobelowTransformerOption) (*sobelowTransformer, error) { return nil, err } - target, err := env.GetOrDefault( - "SOBELOW_TARGET_TYPE", - TargetTypeRepository.String(), - env.WithDefaultOnError(true), - ) - if err != nil { - return nil, err - } - workspacePath, err := env.GetOrDefault( "WORKSPACE_PATH", "", @@ -101,7 +78,6 @@ func New(opts ...SobelowTransformerOption) (*sobelowTransformer, error) { } t := sobelowTransformer{ - targetType: TargetType(target), clock: clockwork.NewRealClock(), resultsDirPath: resultsDirPath, workspacePath: workspacePath, @@ -116,8 +92,6 @@ func New(opts ...SobelowTransformerOption) (*sobelowTransformer, error) { switch { case t.resultsDirPath == "": return nil, errors.New("invalid empty results directory path") - case t.targetType == "": - return nil, errors.New("invalid empty target type") } return &t, nil