Skip to content

Commit 5201b80

Browse files
committed
Refactor Dockerfile dependency package declarations for improved readability
1 parent d358682 commit 5201b80

5 files changed

Lines changed: 73 additions & 12 deletions

File tree

‎src/variations/cli/Dockerfile‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,11 @@ ARG PHP_VARIATION='cli'
77
##########
88
FROM php:${PHP_VERSION}-${PHP_VARIATION}-${BASE_OS_VERSION}
99

10-
ARG DEPENDENCY_PACKAGES_ALPINE='shadow'
11-
ARG DEPENDENCY_PACKAGES_DEBIAN='procps zip'
10+
ARG DEPENDENCY_PACKAGES_ALPINE="\
11+
shadow"
12+
ARG DEPENDENCY_PACKAGES_DEBIAN="\
13+
procps \
14+
zip"
1215
ARG DEPENDENCY_PHP_EXTENSIONS='opcache pcntl pdo_mysql pdo_pgsql redis zip'
1316
ARG PHP_EXTENSION_OVERRIDES=''
1417
ARG REPOSITORY_BUILD_VERSION='dev'

‎src/variations/fpm-apache/Dockerfile‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,15 @@ RUN docker-php-serversideup-s6-install
2222
# FPM-APACHE: Main Image
2323
##########
2424
FROM ${BASE_IMAGE}
25-
ARG DEPENDENCY_PACKAGES_ALPINE='fcgi apache2 shadow'
26-
ARG DEPENDENCY_PACKAGES_DEBIAN='libfcgi-bin apache2 procps zip'
25+
ARG DEPENDENCY_PACKAGES_ALPINE="\
26+
apache2 \
27+
fcgi \
28+
shadow"
29+
ARG DEPENDENCY_PACKAGES_DEBIAN="\
30+
apache2 \
31+
libfcgi-bin \
32+
procps \
33+
zip"
2734
ARG DEPENDENCY_PHP_EXTENSIONS='mysqli opcache pcntl pdo_mysql pdo_pgsql redis zip'
2835
ARG PHP_EXTENSION_OVERRIDES=''
2936
ARG REPOSITORY_BUILD_VERSION='dev'

‎src/variations/fpm-nginx/Dockerfile‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,15 @@ RUN \
9797
# FPM-NGINX: Main Image
9898
##########
9999
FROM ${BASE_IMAGE}
100-
ARG DEPENDENCY_PACKAGES_ALPINE='fcgi gettext shadow'
101-
ARG DEPENDENCY_PACKAGES_DEBIAN='libfcgi-bin gettext-base procps zip'
100+
ARG DEPENDENCY_PACKAGES_ALPINE="\
101+
fcgi \
102+
gettext \
103+
shadow"
104+
ARG DEPENDENCY_PACKAGES_DEBIAN="\
105+
gettext-base \
106+
libfcgi-bin \
107+
procps \
108+
zip"
102109
ARG DEPENDENCY_PHP_EXTENSIONS='opcache pcntl pdo_mysql pdo_pgsql redis zip'
103110
ARG PHP_EXTENSION_OVERRIDES=''
104111
ARG REPOSITORY_BUILD_VERSION='dev'

‎src/variations/fpm/Dockerfile‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,13 @@ ARG PHP_VARIATION='fpm'
77
##########
88
FROM php:${PHP_VERSION}-${PHP_VARIATION}-${BASE_OS_VERSION}
99

10-
ARG DEPENDENCY_PACKAGES_ALPINE='fcgi shadow'
11-
ARG DEPENDENCY_PACKAGES_DEBIAN='libfcgi-bin procps zip'
10+
ARG DEPENDENCY_PACKAGES_ALPINE="\
11+
fcgi \
12+
shadow"
13+
ARG DEPENDENCY_PACKAGES_DEBIAN="\
14+
libfcgi-bin \
15+
procps \
16+
zip"
1217
ARG DEPENDENCY_PHP_EXTENSIONS='opcache pcntl pdo_mysql pdo_pgsql redis zip'
1318
ARG PHP_EXTENSION_OVERRIDES=''
1419
ARG REPOSITORY_BUILD_VERSION='dev'

‎src/variations/frankenphp/Dockerfile‎

Lines changed: 43 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,42 @@ FROM golang:${GOLANG_VERSION} AS golang-image
5252
FROM common AS frankenphp-build
5353
ARG FRANKENPHP_VERSION
5454
ARG GOLANG_VERSION
55-
ARG BUILD_DEPENDENCY_PACKAGES_ALPINE='argon2-dev bash brotli-dev ca-certificates coreutils curl-dev git gnu-libiconv-dev libcap libsodium-dev cmake libstdc++ libxml2-dev linux-headers mailcap oniguruma-dev openssl-dev readline-dev sqlite-dev upx'
56-
ARG BUILD_DEPENDENCY_PACKAGES_DEBIAN='cmake git libargon2-dev libbrotli-dev libcap2-bin libcurl4-openssl-dev libonig-dev libreadline-dev libsodium-dev libsqlite3-dev libssl-dev libxml2-dev mailcap zlib1g-dev'
55+
ARG BUILD_DEPENDENCY_PACKAGES_ALPINE="\
56+
argon2-dev \
57+
bash \
58+
brotli-dev \
59+
ca-certificates \
60+
cmake \
61+
coreutils \
62+
curl-dev \
63+
git \
64+
gnu-libiconv-dev \
65+
libcap \
66+
libsodium-dev \
67+
libstdc++ \
68+
libxml2-dev \
69+
linux-headers \
70+
mailcap \
71+
oniguruma-dev \
72+
openssl-dev \
73+
readline-dev \
74+
sqlite-dev \
75+
upx"
76+
ARG BUILD_DEPENDENCY_PACKAGES_DEBIAN="\
77+
cmake \
78+
git \
79+
libargon2-dev \
80+
libbrotli-dev \
81+
libcap2-bin \
82+
libcurl4-openssl-dev \
83+
libonig-dev \
84+
libreadline-dev \
85+
libsodium-dev \
86+
libsqlite3-dev \
87+
libssl-dev \
88+
libxml2-dev \
89+
mailcap \
90+
zlib1g-dev"
5791

5892
COPY --from=golang-image /usr/local/go /usr/local/go
5993
ENV PATH="/usr/local/go/bin:${PATH}"
@@ -114,8 +148,13 @@ RUN if cat /etc/os-release | grep -q 'debian'; then \
114148
# FrankenPHP Final
115149
####################
116150
FROM common AS final
117-
ARG DEPENDENCY_PACKAGES_ALPINE='shadow libstdc++'
118-
ARG DEPENDENCY_PACKAGES_DEBIAN='procps libstdc++6 zip'
151+
ARG DEPENDENCY_PACKAGES_ALPINE="\
152+
libstdc++ \
153+
shadow"
154+
ARG DEPENDENCY_PACKAGES_DEBIAN="\
155+
libstdc++6 \
156+
procps \
157+
zip"
119158
ARG DEPENDENCY_PHP_EXTENSIONS='opcache pcntl pdo_mysql pdo_pgsql redis zip'
120159
ARG PHP_EXTENSION_OVERRIDES=''
121160
ARG REPOSITORY_BUILD_VERSION='dev'

0 commit comments

Comments
 (0)