diff --git a/.changeset/clean-spiders-smile.md b/.changeset/clean-spiders-smile.md new file mode 100644 index 000000000..6b9d899a6 --- /dev/null +++ b/.changeset/clean-spiders-smile.md @@ -0,0 +1,5 @@ +--- +"@sei-js/registry": patch +--- + +Stop running Git submodule commands when consumers install the registry package. diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 81c0bcbd0..3db494178 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -10,6 +10,7 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 # Fetch the full history instead of a shallow clone + submodules: recursive - uses: actions/setup-node@v4 with: diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index f3292fa9b..7817f9ad3 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -18,6 +18,7 @@ jobs: uses: actions/checkout@v4 with: fetch-depth: 0 # Fetch the full history instead of a shallow clone + submodules: recursive - name: Use Node.js uses: actions/setup-node@v4 with: diff --git a/REVIEW.md b/REVIEW.md index bde73246a..fd1467d19 100644 --- a/REVIEW.md +++ b/REVIEW.md @@ -84,10 +84,10 @@ defect. startup is the intent. Do not ask for a thrown error the caller might swallow. - **`packages/registry/chain-registry` and `.../community-assetlist` are missing from the tree.** Both are git submodules (`.gitmodules`) and are - listed in `.gitignore`. Only `release.yml` checks them out with - `submodules: recursive`; the PR gate in `checks.yml` does a plain checkout - and relies on the `registry` package's `postinstall`. Their JSON is vendored - upstream — review the TypeScript wrappers, not the data. + listed in `.gitignore`. Workflows that build the registry check them out with + `submodules: recursive`; local source builds must initialize them explicitly. + Their JSON is vendored upstream — review the TypeScript wrappers, not the + data. - **Biome findings are not enforced anywhere.** `biome.json` configures tabs, 160-column lines, single quotes and no trailing commas, but no package defines a `biome` script and `.github/workflows/checks.yml` runs only diff --git a/packages/registry/package.json b/packages/registry/package.json index 9c5526432..1dbe8a4fa 100644 --- a/packages/registry/package.json +++ b/packages/registry/package.json @@ -14,8 +14,7 @@ "build:cjs": "tsc --outDir dist/cjs --module commonjs", "build:esm": "tsc --outDir dist/esm --module esnext", "build:types": "tsc --project ./tsconfig.declaration.json", - "test": "jest", - "postinstall": "git submodule update --init --recursive" + "test": "jest" }, "homepage": "https://github.com/sei-protocol/sei-js#readme", "keywords": [