Velopack allows uninstall while the viewer is running & viewer crashes (obviously)

[canny]

• Log in on a Velopack viewer.

• Go to Windows "Add / Remove Programs"

• Uninstall the Velopack viewer.

Observed Behaviour

• You are able to uninstall the viewer while logged in on it

• The viewer instantly crashes

• Any settings changed that session are lost

Expected Behaviour

• You should not be allowed to uninstall the viewer while it is running

• Velopack should check if another application with the same window class is running

https://secondlife.canny.io/admin/feedback/bug-reports/p/velopack-allows-uninstall-while-the-viewer-is-running-viewer-crashes-obviously

---

This repo is using Opire - what does it mean? 👇

💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #5629 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @canny[bot] (replace 20 with the amount, and @canny[bot] with the user to tip).

📖 If you want to learn more, check out our documentation.

[canny]

This issue has been linked to a Canny post: Velopack allows uninstall while the viewer is running & viewer crashes (obviously) 🎉

[jellyfish-linden]

Somebody on the FS dev team suggested this has to do with checking the window class during uninstall. Might want to also check the install process too.

[akleshchev]

Somebody on the FS dev team suggested this has to do with checking the window class during uninstall. Might want to also check the install process too.

FS are talking about NSIS tracking 'window class'. Velopack doesn't seem to do that natively, potentially we can use BeforeUninstall hook.