"Copy SLURL" from Favorites bar not working.

[canny]

Repro steps:

1. Right-click a favorite, either from your Favorites Bar or from Inventory/My Favorites folder.
2. In the context menu, click Copy Slurl
3. If no dialog appears you have reproduced the bug.
4. Continue with the other favorites until you hit the bug.

Observed: If you hit the bug, there will be no dialog with "The following SLurl has been copied..."
If the bug did not reproduce, try the next Favorite. If it does not reproduce with any of your Favorites, ping dan linden for a landmark.

Expected: The SLurl should copy (for any region that is actually online)

---

Original report:
Right click on favorite location, pick Copy SLURL. When I try to paste, that hasn't been picked up, and it pastes my previous copy (in this case a gyazo image). I know I'm using Firestorm, but Oatmeal Linden asked me to create this, so apparently it's a SL thing, not FS.

https://secondlife.canny.io/admin/board/bug-reports/p/copy-slurl-from-favorites-bar-not-working

---

Test setup

• Get a copy of the following 3 landmarks and put them in your Inventory
• 1 (The landmark at https://maps.secondlife.com/secondlife/Danger!%20Danger!/72/81/39)
• 2 (The landmark at https://maps.secondlife.com/secondlife/Danger!%20Danger!/72/80/39)
• 3 (The landmark at https://maps.secondlife.com/secondlife/Danger!%20Danger!/72/79/39)

Test Landmark 1

1. Right-click landmark 1, either from your Favorites Bar or from Inventory/My Favorites folder, and in the context menu, click Copy Slurl
2. Verify a modal dialog appears with the message; The following SLurl has been copied to your clipboard: By Design (116,92,22)
3. Paste into chat and verify the SLurl is pasted.
4. Right-click landmark 1, and choose Show on Map.
5. Verify the world map opens and the landmark location is highlighted.

Test Landmark 2

1. Right-click landmark 2, either from your Favorites Bar or from Inventory/My Favorites folder, and in the context menu, click Copy Slurl
2. Verify a modal dialog appears with the message; "Viewer wasn't able to get the region's location. Region might be temporarily unavailable, was removed or landmark failed to load."
3. Right-click landmark 2, and choose Show on Map.
4. Verify the world map opens and a location in the void is highlighted blue and says Loading… (This behavior may change in the future if a region is placed there.)

Test Landmark 3

1. Right-click landmark 3, either from your Favorites Bar or from Inventory/My Favorites folder, and in the context menu, click Copy Slurl
2. Verify a modal dialog appears with the message; "Viewer wasn't able to get the region's location. Region might be temporarily unavailable, was removed or landmark failed to load."
3. Right-click landmark 3, and choose Show on Map.
4. Verify the world map does not open. Verify there is no error message.

[canny]

This issue has been linked to a Canny post: "Copy SLURL" from Favorites bar not working. 🎉

[akleshchev]

Sometimes viewer can't generate that surl bacause asset wasn't loaded. Perhaps we can cache that?
May be should disable that option when asset isn't there and request asset immediately when right clicking a landmark,

[canny]

This issue has been linked to a Canny post: Copying landmark from FavBar copies AgentId instead. 🎉

[akleshchev]

Will disable the menu button until asset/region is ready.

Currently a lanmark holds a region handle and position within the region, if region does not exist for whatever reason, getting position will fail.