Skip to content

mshv-bindings does not export vmm_sys_util::errno::Error #228

Description

@ludfjig

many mshv-bindings functions return type Result<T> = std::result::Result<T, vmm_sys_util::errno::Error>

To deal with this error type, hyperlight uses thiserror, and we define a variant like so

    /// vmm sys Error Occurred
    #[error("vmm sys Error {0:?}")]
    #[cfg(target_os = "linux")]
    VmmSysError(#[from] vmm_sys_util::errno::Error),

However, because mshv-bindings does not reexport vmm_sys_util::errno::Error, we need to bring in our own dependency on vmm_sys_util, which may or may not be the same version as the one mshv-bindings use. This can lead to the crates breaking unexpectedly (and has done before).

I propose that you add a pub reexport of vmm_sys_util::errno::Error to make this easier.

Feedback appreciated

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions