-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Prevent run-make test recipes (rmake.rs) from using *any* unstable features #137532
Copy link
Copy link
Closed
Closed
Copy link
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Three
rmake.rsuseunstablefeatures that cannot be used (because they need to be build by the stage0 compiler which usually is not a nightly compiler), and needs to be fixed (this was a bug in the previous infra implementation and partially rectified in #137373):tests/run-make/issue-107495-archive-permissions/rmake.rs:rust/tests/run-make/issue-107495-archive-permissions/rmake.rs
Line 1 in f43e549
tests/run-make/cross-lang-lto/rmake.rs:rust/tests/run-make/cross-lang-lto/rmake.rs
Line 6 in f43e549
tests/run-make/broken-pipe-no-ice/rmake.rs:rust/tests/run-make/broken-pipe-no-ice/rmake.rs
Line 14 in f43e549
After these tests are fixed and #137373 merges, we need to:
rmake.rswithRUSTC_BOOTSTRAP=-1to prevent any nightly feature usages withinrmake.rsrecipes by convincing the stage 0 compiler used to buildrmake.rsthat it is a stable-channel compiler. Preventrmake.rsfrom using unstable features, and fix 3 run-make tests that currently do #137537rmake.rsfrom using unstable features, and fix 3 run-make tests that currently do #137537FIXME
os_pipewithanonymous_pipeonce it stabilizes and reaches beta. cf. Stabilizeanonymous_pipe#135822 or Stablize anonymous pipe #137793.os_pipeworkaround now thatanonymous_pipeis stable on beta #139976