-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Audit debug test runners to drop --test-args clang filters on run-make tests #132034
Copy link
Copy link
Closed
Closed
Tracking Issue
Copy link
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsC-bugCategory: This is a bug.Category: This is a bug.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsC-bugCategory: This is a bug.Category: This is a bug.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for Tracking Issue.
Context
Only two CI jobs have
RUSTBUILD_FORCE_CLANG_BASED_TESTS 1set, which is a necessary condition for//@ needs-force-clang-based-testsrun-make tests to run. These tests (at the time when this issue was opened) pass a--test-args clangfilter to the run-make test suite, meaning only run-make tests withclangin their name will run. This is a footgun which meant that several//@ needs-force-clang-based-testsrun-make tests never ran in any CI jobs.Known test runners:
x86_64-gnu-debugrun-maketest suite inx86_64-gnu-debug#131917aarch64-gnu-debugaarch64-gnu-debugfrom the shackles of--test-args=clang#132646