-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Audit usage of command_output methods in rmake.rs tests #125617
Copy link
Copy link
Closed
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
They are typically not the semantics that's desired, i.e. they only provide the command output but does not assert that the command status is success. We should make sure we're not silently letting failed commands through.
Do we even want to allow
command_outputmethods? It's likely less footgunny if we only providedCommandWrapper::{run, run_fail, run_fail_assert_exit_code}methods which perform asserts on the command exit status.