regression: cannot move out of shared reference

[Mark-Simulacrum]

I suspect these may relate to the packed hard error, but it's not very clear what has changed here. Maybe a bisection will help. (I seem to recall a change in derive desugaring, maybe this is caused by that? It did have known regressions at the time, IIRC, though this seems like more than I recall).

• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/icu_locale_canonicalizer-0.6.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/gh/ashkitten.roccat-tools/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/gh/ecumene.bindgen-rust-bt-sdp/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/gh/mars-research.binunpack-rs/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/gh/numerodix.pcitools/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/gh/oussama.twain/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/gh/skreborn.bluetooth-sys/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/apache-nimble-sys-0.0.1/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/bluetooth-sys-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/icu_locale_canonicalizer-0.6.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/libpijul-compat-0.10.2/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/linux-usb-functionfs-sys-0.1.1/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/ntfs-3g-sys-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/seadawg-0.1.3/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/traildb-sys-0.6.3/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.69-3/beta-2023-03-18/reg/twain-0.1.0/log.txt

[lqd]

I think it's indeed because the packed hard error and derive on packed structs changes both landed in 1.69.

twain-0.1.0, icu_locale_canonicalizer-0.6.0, or mars-research.binunpack-rs, all bisect to the latter, but the fact that they compiled on crater since 1.62 is likely because the deny-by-default lint was capped.

[Mark-Simulacrum]

Yep, sounds right. #104429 (comment) is the comment with explanation of the changes in derive on packed structs.

Removing prioritization, this seems like something we can just mention in relnotes as expected breakage.