Skip to content

Commit 1c4bfef

Browse files
authored
Merge pull request #1009 from ndossche/clesss-1
Fix memory leak if sk_push fails
2 parents 785b67a + b53628b commit 1c4bfef

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

ext/openssl/ossl.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@ ossl_##name##_ary2sk0(VALUE ary) \
3434
" of class ##type##"); \
3535
} \
3636
x = dup(val); /* NEED TO DUP */ \
37-
sk_##type##_push(sk, x); \
37+
if (!sk_##type##_push(sk, x)) { \
38+
type##_free(x); \
39+
sk_##type##_pop_free(sk, type##_free); \
40+
ossl_raise(eOSSLError, NULL); \
41+
} \
3842
} \
3943
return (VALUE)sk; \
4044
} \

0 commit comments

Comments
 (0)