Skip to content

[BUG] Dead --film-* CSS variables in globals.css contradict the actual Tailwind color mapping #1772

Open

Description

@magic-peach

Bug description
src/app/globals.css defines raw CSS custom properties --film-600 / --film-400 with literal hex values that differ between light (globals.css:19-20, #e63946/#ff6b6b) and dark (:65-66, #FF6666/#66FF66) mode. But tailwind.config.ts:22-34 completely overrides the film color scale used everywhere in components (text-film-600, border-film-400, etc.) to route through var(--accent) / var(--accent-hover) instead — a different variable entirely. A repo-wide grep confirms var(--film-*) is never actually referenced anywhere in src/.

Steps to reproduce

  1. grep -n "film-600\|film-400" src/app/globals.css
  2. grep -n "film:" tailwind.config.ts
  3. grep -rn "var(--film" src/ → zero results

Expected behavior
Either the raw --film-* variables are actually used somewhere and this is a latent theming bug waiting to surface, or they're dead code that should be removed to avoid confusing a future contributor who reasonably assumes --film-600 is what text-film-600 resolves to.

Actual behavior
Two parallel, disconnected definitions of "film-600" exist with different values; the CSS one is unused.

Related to the broader #673 "dark mode audit" issue, but this is a specific, immediately actionable finding rather than something a general audit would necessarily catch (it's dead code, not a rendering bug).

Activity

  1. added
    bugSomething isn't working correctly
    good first issueGood for newcomers and beginners
    gssoc'26GirlScript Summer of Code 2026
    refactorCode quality and refactoring
    on Sep 15, 2026
  2. github-actions commented on Sep 15, 2026

    @github-actions
    Contributor

    👋 Thanks for opening an issue, @magic-peach!

    Our maintainers will review this shortly 🚀

    Before you start working

    • 📖 Read the CONTRIBUTING.md guide
    • 💬 Wait for a maintainer to assign you the issue before starting work
    • 🔍 Search for existing issues to avoid duplicates

    For GSSoC'26 contributors

    If you're contributing under GirlScript Summer of Code 2026, please mention it in your comment when requesting assignment:

    "I'd like to work on this — contributing under GSSoC'26"

    Architecture notes

    Reframe is a static Next.js app with output: "export". Key points:

    • All video processing uses FFmpeg.wasm (client-side, no server)
    • headers() in next.config.ts won't work — use vercel.json instead
    • not-found.tsx requires public/404.html + vercel.json routes config

    Happy contributing! ⭐ Star the repo if you find it useful!

  3. github-actions commented on Sep 15, 2026

    @github-actions
    Contributor

    Claude encountered an error —— View job


    I'll analyze this and get back to you.

  4. yashprakash47 commented on Sep 25, 2026

    @yashprakash47

    Hi! I'd like to work on this issue. I'm a first-time contributor to Reframe.
    Could you please assign this issue to me?

  5. added a commit that references this issue on Oct 17, 2026
    9c7ce67
  6. github-actions commented on Oct 29, 2026

    @github-actions
    Contributor

    👋 This issue has been inactive for 30 days. It will be automatically closed in 14 days if there's no further activity.

    If you're still interested in working on this, please leave a comment!
    For GSSoC'26 contributors: make sure to keep your assigned issues active.

    ⭐ Star Reframe if you find it useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working correctlygood first issueGood for newcomers and beginnersgssoc'26GirlScript Summer of Code 2026level:beginnerBeginner level - 20 ptsneeds investigationNeeds more investigation before work beginsrefactorCode quality and refactoringtype:bugBug fixtype:designUI/UX designtype:refactorCode refactor

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions