From 732c879c5baac963809829364963bd182acb2162 Mon Sep 17 00:00:00 2001 From: Hector Espert Date: Sat, 11 Jul 2026 12:40:54 +0200 Subject: [PATCH 1/3] fix: update Go version to 1.26.2 and fix format string in fmt.Errorf - Update go.mod to Go 1.26.2 - Update workflow to use Go 1.26.2 - Fix non-constant format string error in ads1x15/factory.go - Go 1.26.2 enforces constant format strings for fmt.Errorf - All tests passing locally Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/go.yml | 4 ++-- ads1x15/factory.go | 4 ++-- go.mod | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index e650f0b..a31614a 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -7,9 +7,9 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-go@v2 with: - go-version: '^1.16.1' - - uses: codecov/codecov-action@v1 + go-version: '1.26.2' - run: sudo apt-get install libasound2-dev -y - run: go get golang.org/x/tools/cmd/goimports - run: go test ./... + - uses: codecov/codecov-action@v1 - run: go build ./... diff --git a/ads1x15/factory.go b/ads1x15/factory.go index 25155ed..7f3188f 100644 --- a/ads1x15/factory.go +++ b/ads1x15/factory.go @@ -106,12 +106,12 @@ func parseGain(v interface{}) (string, error) { if !ok { failure := fmt.Sprint(" is not a string. ", v, " was received.") - return "", fmt.Errorf(failure) + return "", fmt.Errorf("%s", failure) } if _, ok = gainOptions[val.(string)]; !ok { failure := fmt.Sprint(" is not a valid value of 2/3, 1, 2, 4, 8, or 16. ", v, " was received.") - return "", fmt.Errorf(failure) + return "", fmt.Errorf("%s", failure) } return val.(string), nil diff --git a/go.mod b/go.mod index cfeac28..c7a0389 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/reef-pi/drivers -go 1.23.2 +go 1.26.2 require ( github.com/hajimehoshi/go-mp3 v0.3.4 From 814ce78ba6fc4b9d1cd83db14bb506d42a711d52 Mon Sep 17 00:00:00 2001 From: Hector Espert Date: Sat, 11 Jul 2026 12:47:00 +0200 Subject: [PATCH 2/3] Update imports --- go.mod | 6 +++++- go.sum | 10 ++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index c7a0389..0ab1bd8 100644 --- a/go.mod +++ b/go.mod @@ -13,5 +13,9 @@ require ( golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8 // indirect golang.org/x/image v0.18.0 // indirect golang.org/x/mobile v0.0.0-20190415191353-3e0bab5405d6 // indirect - golang.org/x/sys v0.28.0 // indirect + golang.org/x/mod v0.38.0 // indirect + golang.org/x/sync v0.22.0 // indirect + golang.org/x/sys v0.47.0 // indirect + golang.org/x/telemetry v0.0.0-20260708182218-49f421fb7959 // indirect + golang.org/x/tools v0.48.0 // indirect ) diff --git a/go.sum b/go.sum index 31aac54..03b9b31 100644 --- a/go.sum +++ b/go.sum @@ -14,9 +14,19 @@ golang.org/x/image v0.18.0 h1:jGzIakQa/ZXI1I0Fxvaa9W7yP25TqT6cHIHn+6CqvSQ= golang.org/x/image v0.18.0/go.mod h1:4yyo5vMFQjVjUcVk4jEQcU9MGy/rulF5WvUILseCM2E= golang.org/x/mobile v0.0.0-20190415191353-3e0bab5405d6 h1:vyLBGJPIl9ZYbcQFM2USFmJBK6KI+t+z6jL0lbwjrnc= golang.org/x/mobile v0.0.0-20190415191353-3e0bab5405d6/go.mod h1:E/iHnbuqvinMTCcRqshq8CkpyQDoeVncDDYHnLhea+o= +golang.org/x/mod v0.38.0 h1:MECBjubtXD7yj4HrhIUcywNaGeNVUdfVnxmPajOk4yk= +golang.org/x/mod v0.38.0/go.mod h1:V6Xz0pq8TQ3dGqVQ1FVHuelZpAL0uNhSkk9ogYP3c40= +golang.org/x/sync v0.22.0 h1:SZjpbeLmrCk4xhRSZFNZW5gFUeCeFgjekvI/+gfScek= +golang.org/x/sync v0.22.0/go.mod h1:9xrNwdLfx4jkKbNva9FpL6vEN7evnE43NNNJQ2LF3+0= golang.org/x/sys v0.0.0-20190312061237-fead79001313/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190429190828-d89cdac9e872/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20220712014510-0a85c31ab51e/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA= golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= +golang.org/x/sys v0.47.0 h1:o7XGOvZQCADBQQ4Y7VNq2dRWQR7JmOUW8Kxx4ZsNgWs= +golang.org/x/sys v0.47.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw= +golang.org/x/telemetry v0.0.0-20260708182218-49f421fb7959 h1:RJhm5l6Fo4rmEIcndxDllNhhf/fAx8qIm4t6A7vpm2A= +golang.org/x/telemetry v0.0.0-20260708182218-49f421fb7959/go.mod h1:LV7u5Oco+Z/g6XI7PqN+EUUUGGkEcmB1uj2ceI0fOVg= golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= +golang.org/x/tools v0.48.0 h1:3+hClM1aLL5mjMKm5ovokw9epgRXPuu2tILgismM6RE= +golang.org/x/tools v0.48.0/go.mod h1:08xX0orndb/F7jJxGDicx061tyd5pcMto75YMAXr6lk= From eeba080e2337ef107e84706479ea78751ebdf0f2 Mon Sep 17 00:00:00 2001 From: Hector Espert Date: Sat, 11 Jul 2026 12:56:28 +0200 Subject: [PATCH 3/3] ci: replace codecov with Coveralls for coverage reporting - Remove codecov/codecov-action@v1 (deprecated) - Update go test to generate coverage.txt: go test -coverprofile=coverage.txt ./... - Add Coveralls upload action (coverallsapp/github-action@v2) - Align with reef-pi root project coverage reporting method - All tests passing with coverage tracking Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/go.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index a31614a..13adfb3 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -10,6 +10,11 @@ jobs: go-version: '1.26.2' - run: sudo apt-get install libasound2-dev -y - run: go get golang.org/x/tools/cmd/goimports - - run: go test ./... - - uses: codecov/codecov-action@v1 + - run: go test -coverprofile=coverage.txt ./... + - name: Upload coverage to Coveralls + uses: coverallsapp/github-action@v2 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + file: coverage.txt + format: golang - run: go build ./...